theia icon indicating copy to clipboard operation
theia copied to clipboard

"Close Editor" in the File menu did not get the correct translation value

Open noneghost opened this issue 1 year ago • 0 comments

Bug Description:

"Close Editor" in the File menu did not get the correct translation value after use mater branch.

企业微信截图_17066684863542

Steps to Reproduce:

After #13331

https://github.com/eclipse-theia/theia/blob/b15b639fa3b64a9518efdf3e82ea9098915ba145/packages/editor/src/browser/editor-menu.ts#L180-L184

  1. Get "Close Editor" value when use "Close Editor" key, Get right value when use "close Editor" key.
  2. It may be due to a mismatch in the DefaultKey values obtained by nls.

https://github.com/eclipse-theia/theia/blob/b15b639fa3b64a9518efdf3e82ea9098915ba145/packages/core/src/common/nls.ts#L90-L94

企业微信截图_17066686467715 企业微信截图_17066686828364

Additional Information

  • Theia Version: master branch (commit id: b15b639)

noneghost avatar Jan 31 '24 02:01 noneghost