theia
theia copied to clipboard
eclipse-theia
Backport Issues for 1.45.1
Bug Description:
List of issues to backport for the 1.45.1 Community release
- [x] https://github.com/eclipse-theia/theia/issues/13215
Maybe this one is an easy fix for the next release in order to enable SSH remote development support? https://github.com/eclipse-theia/theia/issues/13294
@planger I don't see any changes to be done for that issue. At least no PR is linked in the issue.
@tsmaeder Yeah, no need for changes immediately, we just need to make sure we also release the native dependencies and upload it to the release. I was just wondering whether we should automate the publishing of the native dependencies in the release pipeline, otherwise we may forget it in the future again, breaking the remote SSH support.
That does not sound like something for a patch release. Also, I am not aware that we need to do anything for the patch release regarding native dependencies, etc. I'm just the piano player.
That does not sound like something for a patch release. Also, I am not aware that we need to do anything for the patch release regarding native dependencies, etc. I'm just the piano player.
Well, we need to ensure that the release artifacts (also for the patch release) include the native dependency archives, because the URL to download them into the remote machine is constructed from the concrete Theia version (see app-native-dependency-contribution.ts#L39), which is different also between a patch release and the .0 release. Since there doesn't seem to be an automatic workflow, we need to upload the native dependency archives to the dot release in Github manually, afaik.
But it does sound like a great issue to open ;-)
Definitely, I'll create an issue.
We should be able to modify the existing dispatch workflow that generates the artifacts to automatically attach them to each release.
I've added https://github.com/eclipse-theia/theia/issues/13308 to track the automation of this step.
@tsmaeder The 1.45.1 release should be fine, because it already contains the native dependency artifacts (probably @msujew added them manually).
@msujew could you add steps to https://github.com/eclipse-theia/theia/blob/master/doc/Publishing.md in case we don't have the automation ready for the next release (tomorrow ;-))?
@tsmaeder I've notified Vince that these files should be added to the release. In the worst case I'm going to add them manually again. It's probably not worth the effort of adding (and then removing) stuff from the documentation.