eclipse-theia
[debug] Wait for debugger capabilities initialization before breakpoint update
What it does
Fixes: https://github.com/eclipse-theia/theia/issues/11606 Fix an issue where debugger doesn't send breakpoints on first run.
How to test
- Open any project in Theia.
- Switch to the debugger tab.
- Add function breakpoint by clicking on "Add Function Breakpoint" button.
- Run debugger.
- Make sure that debugger wait for capability initialization and catches breakpoints correctly.
Review checklist
- [x] As an author, I have thoroughly tested my changes and carefully followed the review guidelines
Reminder for reviewers
- As a reviewer, I agree to behave in accordance with the review guidelines
@Vakosta I'm having trouble to test this successfully, since the Node.js debugger doesn't support function breakpoints at all. What language/extension are you using to test this?
@msujew Language and extension are internal commercial development in the company, where I work. Unfortunately, I can't name them, because they are under NDA.
@msujew as an author of another debug adapter (https://marketplace.visualstudio.com/items?itemName=EvilBeaver.oscript-debug) I think this is a good fix and capabilities now should work better. What else should be done to make this PR merged?
@vince-fugnitto Do you think it's alright to include this change in the upcoming release or should we merge it shortly afterwards to catch potential issues?
@msujew I'd wait for right after the release since we didn't get the opportunity to test the actual functionality of the change as no plugin was provided.
