theia
theia copied to clipboard
eclipse-theia
Wait for plugins to deploy before restoring the current language
we will definitely have to deal with the problem of 90% of Theia not being translated.
This would be true only during the loading time, right?
But yes, I would go for the other solution too, I just couldn't find a way to await for the languages loading process. Probably I've just didn't dig deep enough (and also didn't know how waiting for it would affect the Theia loading time)
This would be true only during the loading time, right?
Yes, but that's the issue. We already load translations during loading time. The /i18n/:locale endpoint not only returns metadata on languages, but all of the translations as well, since they need to be available at the time of loading the JS code.
@msujew I see. Thanks for the tip, I think I've found a better solution here
if you like it, I'd gladly update this PR with that code.
@AlbyIanna Sure, something similar should work for the Theia codebase as well 👍
Don't forget to sign the ECA by the way.
You'll have to create a dedicated override in the plugin-ext package for the LocalizationBackendContribution and bind it there.
@msujew I'm not sure how to proceed here. Could you please provide me with an example of how to do that?
Also we can't accept your changes when you haven't signed the ECA. Please do so.
I should have done it now. Can you please confirm I did it right?
I'm not sure how to proceed here. Could you please provide me with an example of how to do that?
Sure, I recently did something similar: There is a core LanguageQuickPickService, which is overriden in the vsx-registry package as VSXLanguageQuickPickService as the services in there aren't available in core.
I should have done it now. Can you please confirm I did it right?
Are you sure you did it with the mail that's in the commit? It doesn't seem to validate.
Are you sure you did it with the mail that's in the commit? It doesn't seem to validate.
Yes, I'm sure about it because I received the confirmation e-mail after the registration.
This is what I see in my Eclipse Account:
Yes, I'm sure about it because I received the confirmation e-mail after the registration.
Alright, cool. It seems to work now. No idea why it didn't work previously.
@msujew thanks for the feedback. In the last commit I've made some changes according to your requests 👍
@AlbyIanna Are you still interested in contributing the changes? I still have a few outstanding comments before approving this.
Hi @msujew, thanks for the review. Sorry for the delay in answering, I must have missed the notification 🙏 I will address your remarks soon.