Conflicting shortcuts for CtrlCmd + Shift + L

[perrinjerome]

Bug Description:

CtrlCmd + Shift + L is mapped to

• "Select All Occurrences of Find Match" by monaco ( https://github.com/microsoft/vscode/blob/dce493cb6e36346ef2714e82c42ce14fc461b15c/src/vs/editor/contrib/multicursor/browser/multicursor.ts#L774 )
• "Toggle plugin view" by theia's plugin-ext

I feel that opening the plugin ext is not something people need to do with "high efficiency" and that this does not really need a shortcut, so a fix I want to suggest is to remove this line where the keyboard is registered in plugin-ext : https://github.com/eclipse-theia/theia/blob/ab55cbea5bd570863fae348d9abaf1a54f0c0624/packages/plugin-ext/src/main/browser/plugin-frontend-view-contribution.ts#L35

Steps to Reproduce:

1. open a text editor
2. search for some string present in the file
3. press CtrlCmd + Shift + L to select all matches
4. the plugin view opens instead of selecting

Additional Information

• Operating System: ChromeOS 104
• Theia Version: current master

[vince-fugnitto]

@perrinjerome I don't believe the bug is necessarily that the plugins-view has a keybinding, more so that Select All Occurrences of Find Match should have priority when the when context is true (editorFocus):

---

Edit: I may have misinterpreted how the when clause works in this case, I thought that with a when clause set it would take precedence over the default none (vscode keyboard rules). In any case I believe it is fine to remove the keybinding for the view which is not all that common.

[perrinjerome]

Thank you @vince-fugnitto I did not notice your edit, I'm sending a pull request to drop the default keybinding in that case.