theia icon indicating copy to clipboard operation
theia copied to clipboard

Terminal link matcher for files does not detect paths containing `+`

Open perrinjerome opened this issue 2 years ago • 0 comments

Bug Description:

Terminal link matcher for files does not detect paths containing +, for example, ./file.txt is clickable but ./file+.txt is not.

Steps to Reproduce:

  1. Open terminal
  2. type touch file.txt file+.txt
  3. type ls ./file*
  4. mouse over ./file.txt, it is a link to open the file in editor
  5. mouse over ./file+.txt , it is not a link.

Screen recording 2022-07-08 19.22.49.webm

The regular expressions to detect links come from vscode and this was reported as an issue on vscode . There have been other issues, for example this one with $. I am going to submit a pull request to update the regular expressions.

Additional Information

  • Operating System: ChromeOS 104
  • Theia Version: current master

perrinjerome avatar Jul 08 '22 10:07 perrinjerome