theia-blueprint icon indicating copy to clipboard operation
theia-blueprint copied to clipboard

Rename theia-updater to @theia/electron-updater

Open JonasHelming opened this issue 4 years ago • 6 comments

After splitting the updater from the rpdocut branding (https://github.com/eclipse-theia/theia-blueprint/pull/43) we should consider renaming the updater extension. It is actually generic, so it could potentially be reused by any other application relying on the electron updater.

JonasHelming avatar Feb 17 '21 14:02 JonasHelming

Should we not also move the updater to the Theia repo, @JonasHelming?

koegel avatar Apr 01 '21 12:04 koegel

Yes, mid term this would probably make sense.

JonasHelming avatar Apr 01 '21 13:04 JonasHelming

We are free to move code around within the project, so it's totally up-to us.

marcdumais-work avatar Apr 01 '21 15:04 marcdumais-work

Should we not also move the updater to the Theia repo, @JonasHelming?

Before we think about moving, we should consider the following:

  • Adding a readme to properly describe this extension (like other extensions).
  • We should only add extensions if they can be easily tested when using example-electron (even manually). Does this extension provide any functionality that can be easily tested with example-electron or is it only useful for packaged electron applications?

vince-fugnitto avatar Apr 01 '21 16:04 vince-fugnitto

From my initial newbie look at theia-updater one may want to consider breaking out the url/directory strings in theia-updater-impl.ts into something configurable.

seltzered avatar Nov 21 '22 02:11 seltzered

From my initial newbie look at theia-updater one may want to consider breaking out the url/directory strings in theia-updater-impl.ts into something configurable.

This would make sense and we would accept a PR, currently we have no plans to make the updater more generic, therefore we put it in the Backlog milestone some time ago.

koegel avatar Nov 22 '22 20:11 koegel