generator-theia-extension icon indicating copy to clipboard operation
generator-theia-extension copied to clipboard

Add badge to Readme showing the status of the "next" build

Open JonasHelming opened this issue 3 years ago • 5 comments
trafficstars

If the build on main fails, it is likely that the underlying Theia project has some API breakage. We should notify interested parties, either some committer or a mailing list in this case. @vince-fugnitto @marcdumais-work Any thoughts on this?

see also https://github.com/eclipse-theia/generator-theia-extension/pull/122 introducing a build against "next"

JonasHelming avatar Nov 28 '21 20:11 JonasHelming

@JonasHelming I think the mailing list would be too noisy if we start sending emails when the build fails, perhaps whoever is interested can turn on their settings for failed builds? The only issue is that it might not be granular to which repo they want notifications for:

image

We could also add a badge in the main-repo's readme (similarly to vscode-builtin-extensions) to display the build status of the generator.

vince-fugnitto avatar Nov 29 '21 13:11 vince-fugnitto

@vince-fugnitto Do you get notifications on this repo? If so, if it is at least you and me, I believe we are good already.

JonasHelming avatar Nov 29 '21 20:11 JonasHelming

@vince-fugnitto Do you get notifications on this repo? If so, if it is at least you and me, I believe we are good already.

@JonasHelming I believe so, and I agree that it's likely enough, we would not want to add noise to the mailing list about failed builds in the generator :+1:

vince-fugnitto avatar Nov 30 '21 13:11 vince-fugnitto

OK let us wait until the tree editor is fixed then

JonasHelming avatar Nov 30 '21 13:11 JonasHelming

Depending on the outcome of the discussion here: https://github.com/eclipse-theia/theia-blueprint/pull/186 We also might want to add the badge to the Theia repo

JonasHelming avatar Dec 10 '21 20:12 JonasHelming