ferry import in osmWebWizard

[behrisch]

May need an extra option or could be always done if public transport is enabled

[namdre]

currently works by adding some random ships (by triggering the osmNetconvertShips.typ.xml typemap to be added).

[behrisch]

extra checkbox below public transport would be nice

[namdre]

Maybe a checkbox for each of 'tram', 'bus', 'train', 'ferry', 'taxi' below the 'import public transport checkbox'. This could easily be passed to ptlines2flows for filtering.

[ozsoyisik]

Hello, I want to be assigned to this issue, I also looked at the code of this part and also experimented OSM wizard. Could you please clarify the issue? I did not quite understand why you were talking about only adding "import ferry option" separately. Then you mentioned that there might be a checkbox for each of them. Is there a specific reason for that? If you can explain the requirement a bit more, I would like to contribute to SUMO. @namdre @behrisch @uekerman

[namdre]

OSM includes data for multiple modes of public transport. The osmWebWizard permits configuring different modes of random traffic and it would be useful to also configure which modes of public transport are included in the final simulation (i.e. no rail transport if the user only needs a roadway simulation). This ticket comprises three parts

• add checkboxes for all public transport modes to the UI below the main 'public transport' checkbox.
• convert the checkbox values to additional ptOptions for calling ptlines2flows.main
• add the ships-typemap to netconvertOptions if the ferry checkbox is active (it should be disabled by default).

[namdre]

@ozsoyisik see https://sumo.dlr.de/docs/FAQ.html#how_do_code_contributions_work

[ozsoyisik]

I checked the website, and already submitted Eclipse Contributor Agreement. If it is okay you can assign me as an assignee and I will follow the contribution guide while implementing.

[ozsoyisik]

@namdre I have some confusions which I want to ask you to clarify. From what I understood, I came up with following:

• If the top-level Import Public Transport checkbox is enabled, netconvert always exports PT stops and ptlines (--ptstop-output and --ptline-output) regardless of which pt checkboxes are selected.
• The pt checkboxes affect only ptlines2flows (via --types), in oder words the public transportation flows; they do not prevent netconvert from exporting stops/ptlines.
• If no modes are selected, I currently do not add --types to ptlines2flows; ptlines2flows then processes all types (default behavior), which can produce flows for modes the user left unchecked.

Does that sound correct, especially the last point. Should enabling Import Public Transport always export PT stops and ptlines even if the user selects no PT modes? Or should we export stop/ptline when at least one PT mode is selected?

[namdre]

points 1 and 2 are correct. For point 3, if no types are checked, ptlines2flows should not be called at all.

[ozsoyisik]

Hello again @namdre , I implemented the code as we talked then I have checked the TOOLS tests since I worked on that package. Then, I saw that some of tests are failing right now. Before I start working on tests, I wanted to ask how should I proceed with the tests and if you have any suggestions for me.

[namdre]

at this time, all tool tests on linux are fine/known bugs and there is a single untagged known platform difference causing test drt/drtOnline/2taxis_10persons/exhaustive_search to fail with slighty different standard output. You may safely ignore that one. To test webwizard internals, you can set option --test-output which will circumvent the UI and use the local file osm_bbox.osm.xml UI should be tested manually for now.