rdf4j icon indicating copy to clipboard operation
rdf4j copied to clipboard

GH-5064: added docker makefile for Jetty 9

Open barthanssens opened this issue 1 year ago • 3 comments

GitHub issue resolved: #5064

Briefly describe the changes proposed in this PR:

  • add docker makefile for Jetty 9
  • updated docker makefile for Tomcat 9 (instead of 8.5)
  • updated e2e tests to run the tests for both Jetty and Tomcat
  • minor updates of documentation
  • added leading slash in overview.jsp to redirect to correct path (Jetty)

PR Author Checklist (see the contributor guidelines for more details):

  • [x] my pull request is self-contained
  • [x] I've added tests for the changes I made
  • [x] I've applied code formatting (you can use mvn process-resources to format from the command line)
  • [x] I've squashed my commits where necessary
  • [x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

barthanssens avatar Jul 18 '24 19:07 barthanssens

The end-to-end tests probably just build the default dockerfile. Could you have it run against both the default/current and the jetty one?

hmottestad avatar Jul 19 '24 12:07 hmottestad

Ah, good thinking, forgot about that

barthanssens avatar Jul 20 '24 09:07 barthanssens

Workbench seems to work, but still an issue with 404 on overview.view on the server

Jetty redirects the "home page" to rdf4j-server/WEB-INF/views/home/overview.view instead of rdf4j-server/home/overview.view

barthanssens avatar Jul 22 '24 18:07 barthanssens