rdf4j icon indicating copy to clipboard operation
rdf4j copied to clipboard

SPARQLStarResultsXMLWriterFactory doesn't return SPARQLStarResultsXMLWriter

Open pulquero opened this issue 3 years ago • 2 comments

See https://github.com/eclipse/rdf4j/blob/b849630bfac9c84e0444390179409456da043b15/core/queryresultio/sparqlxml/src/main/java/org/eclipse/rdf4j/query/resultio/sparqlxml/SPARQLStarResultsXMLWriterFactory.java#L42 I think functionally it works, but just confusing/off-putting when you see SPARQLResultsXMLWriter flying around in the debugger when you're expecting to see something like SPARQLStarResultsXMLWriter.

pulquero avatar Aug 22 '22 08:08 pulquero

Don't think it does work either as encodeRDFStar = this instanceof TupleQueryResultWriter && !((TupleQueryResultWriter) this).getTupleQueryResultFormat().supportsRDFStar() && getWriterConfig().get(BasicWriterSettings.ENCODE_RDF_STAR); I think will do the lookup against SPARQLResultsXMLWriter.

pulquero avatar Aug 22 '22 09:08 pulquero

Thanks for pointing this out!

hmottestad avatar Aug 23 '22 08:08 hmottestad