rdf4j icon indicating copy to clipboard operation
rdf4j copied to clipboard

Remove local maven config file and add .mvn folder to gitignore

Open hmottestad opened this issue 1 year ago • 2 comments

Remove the local maven config file and add the .mvn folder to gitignore.


PR Author Checklist (see the contributor guidelines for more details):

  • [ ] my pull request is self-contained
  • [ ] I've added tests for the changes I made
  • [ ] I've applied code formatting (you can use mvn process-resources to format from the command line)
  • [ ] I've squashed my commits where necessary
  • [ ] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

hmottestad avatar Aug 02 '22 07:08 hmottestad

I'm on mobile so can't check, but I seem to remember we added this for a specific reason: the way we refer to the project root fails in Jenkins or in GitHub when this is not defined, I think. I'll try and look up the details in the commit history.

abrokenjester avatar Aug 02 '22 19:08 abrokenjester

So we introduced this file as part of the PR that introduced automated code formatting checks (see https://github.com/eclipse/rdf4j/pull/1340 ) . At the time this was done because Jenkins was having trouble with the relative path reference we use to link to the code formatting file. I can't remember if adding this was actually the fix, or if this is merely something I used to figure out the version of maven used in Jenkins.

In any case: if you want to remove it, I'd recommend running a test build on Jenkins to make sure the code formatter part of the build doesn't break there.

abrokenjester avatar Aug 02 '22 21:08 abrokenjester