rdf4j
rdf4j copied to clipboard
Lost variable binding since 4.1.0-M1
Current Behavior
Running a query with GraphDB causes:
11:20:12.160 [main] WARN o.e.r.s.d.s.o.TupleQueryResultConverter - Caught execption while processing TupleQueryResult
java.lang.IllegalStateException: BindingSet does not contain binding for variable quantityKind
at org.eclipse.rdf4j.spring.util.QueryResultUtils.lambda$getValue$0(QueryResultUtils.java:44)
at java.base/java.util.Optional.orElseThrow(Optional.java:408)
at org.eclipse.rdf4j.spring.util.QueryResultUtils.getValue(QueryResultUtils.java:42)
at org.eclipse.rdf4j.spring.util.QueryResultUtils.getValue(QueryResultUtils.java:50)
at org.eclipse.rdf4j.spring.util.QueryResultUtils.getIRI(QueryResultUtils.java:54)
at at.researchstudio.sat.merkmalservice.service.entity.feature.Feature.<init>(Feature.java:59)
at at.researchstudio.sat.merkmalservice.service.entity.feature.FeatureDao.fromTupleQueryResult(FeatureDao.java:866)
at org.eclipse.rdf4j.spring.dao.support.operation.TupleQueryResultConverter.applyToResult(TupleQueryResultConverter.java:69)
at org.eclipse.rdf4j.spring.dao.support.operation.TupleQueryResultConverter.toSingletonMaybeOfWholeResult(TupleQueryResultConverter.java:115)
at org.eclipse.rdf4j.spring.dao.support.operation.TupleQueryResultConverter.toSingletonOptionalOfWholeResult(TupleQueryResultConverter.java:120)
at org.eclipse.rdf4j.spring.dao.support.operation.TupleQueryResultConverter.toSingletonOfWholeResult(TupleQueryResultConverter.java:130)
at at.researchstudio.sat.merkmalservice.service.entity.feature.FeatureDao.getFeaturesForStandard(FeatureDao.java:440)
at at.researchstudio.sat.merkmalservice.dao.FeatureDaoTests.testGetFeaturesForStandardOfProject(FeatureDaoTests.java:188)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:686)
at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$6(TestMethodTestDescriptor.java:212)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:208)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:137)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:71)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:135)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:32)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:248)
at org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$5(DefaultLauncher.java:211)
at org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:226)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:199)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:132)
at com.intellij.junit5.JUnit5IdeaTestRunner.startRunnerWithArgs(JUnit5IdeaTestRunner.java:71)
at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
org.eclipse.rdf4j.spring.dao.exception.RDF4JSpringException: Error processing TupleQueryResult
at org.eclipse.rdf4j.spring.dao.exception.mapper.ExceptionMapper.mapException(ExceptionMapper.java:23)
at org.eclipse.rdf4j.spring.dao.support.operation.TupleQueryResultConverter.applyToResult(TupleQueryResultConverter.java:72)
at org.eclipse.rdf4j.spring.dao.support.operation.TupleQueryResultConverter.toSingletonMaybeOfWholeResult(TupleQueryResultConverter.java:115)
at org.eclipse.rdf4j.spring.dao.support.operation.TupleQueryResultConverter.toSingletonOptionalOfWholeResult(TupleQueryResultConverter.java:120)
at org.eclipse.rdf4j.spring.dao.support.operation.TupleQueryResultConverter.toSingletonOfWholeResult(TupleQueryResultConverter.java:130)
at at.researchstudio.sat.merkmalservice.service.entity.feature.FeatureDao.getFeaturesForStandard(FeatureDao.java:440)
at at.researchstudio.sat.merkmalservice.dao.FeatureDaoTests.testGetFeaturesForStandardOfProject(FeatureDaoTests.java:188)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:686)
at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$6(TestMethodTestDescriptor.java:212)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:208)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:137)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:71)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:135)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:32)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:248)
at org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$5(DefaultLauncher.java:211)
at org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:226)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:199)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:132)
at com.intellij.junit5.JUnit5IdeaTestRunner.startRunnerWithArgs(JUnit5IdeaTestRunner.java:71)
at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
Caused by: java.lang.IllegalStateException: BindingSet does not contain binding for variable quantityKind
at org.eclipse.rdf4j.spring.util.QueryResultUtils.lambda$getValue$0(QueryResultUtils.java:44)
at java.base/java.util.Optional.orElseThrow(Optional.java:408)
at org.eclipse.rdf4j.spring.util.QueryResultUtils.getValue(QueryResultUtils.java:42)
at org.eclipse.rdf4j.spring.util.QueryResultUtils.getValue(QueryResultUtils.java:50)
at org.eclipse.rdf4j.spring.util.QueryResultUtils.getIRI(QueryResultUtils.java:54)
at at.researchstudio.sat.merkmalservice.service.entity.feature.Feature.<init>(Feature.java:59)
at at.researchstudio.sat.merkmalservice.service.entity.feature.FeatureDao.fromTupleQueryResult(FeatureDao.java:866)
at org.eclipse.rdf4j.spring.dao.support.operation.TupleQueryResultConverter.applyToResult(TupleQueryResultConverter.java:69)
... 70 more
Expected Behavior
Same code & query, no problems with v4.0.2
Steps To Reproduce
No response
Version
4.1.0-M1
Are you interested in contributing a solution yourself?
Perhaps?
Anything else?
No response
Could you share the query that caused this for you?
PREFIX mms: <https://mms.researchstudio.at/mms#>
PREFIX s: <http://schema.org/>
SELECT DISTINCT ?id ?f_copyOf ?f_standardId ?f_name ?dateCreated ?dateModified ?f_private ?f_description ?creator ?editor ?f_featureKind ?class ?quantityKind ?quantityKindLabel ?unit ?unitLabel ?allowMultiple ?optionId ?optionValue ?optionDescription ( CONCAT( IF( BOUND( ?organizationId ), CONCAT( "/organizations/", REPLACE( STR( ?organizationId ), "urn:uuid:|/|#|:|\\\\.", "" ) ), CONCAT( "/projects/", REPLACE( STR( ?projectId ), "urn:uuid:|/|#|:|\\\\.", "" ) ) ), "/standards/", REPLACE( STR( ?f_standardId ), "urn:uuid:|/|#|:|\\\\.", "" ), "/features/", REPLACE( STR( ?id ), "urn:uuid:|/|#|:|\\\\.", "" ) ) AS ?path )
WHERE { ?id a mms:Feature ;
s:name ?f_name ;
mms:private ?f_private ;
s:dateCreated ?dateCreated ;
s:dateModified ?dateModified ;
s:creator ?creator ;
s:editor ?editor .
?id mms:belongsToStandard ?f_standardId .
OPTIONAL { ?f_standardId mms:belongsToOrganization ?organizationId . }
OPTIONAL { ?f_standardId mms:belongsToProject ?projectId . }
OPTIONAL { ?id s:description ?f_description . }
OPTIONAL { ?id mms:copyOf ?f_copyOf . }
?id mms:dataType ?f_featureKind .
{ ?f_featureKind a ?class .
OPTIONAL { ?f_featureKind a ?class .
FILTER ( ( ?f_featureKind != <http://www.linkedmodel.org/schema/dtype#SimpleCodeList> && ?f_featureKind != mms:DataType ) ) }
OPTIONAL { ?f_featureKind mms:quantityKind ?quantityKind ;
mms:unit ?unit .
?quantityKind <http://www.w3.org/2000/01/rdf-schema#label> ?quantityKindLabel .
?unit <http://www.w3.org/2000/01/rdf-schema#label> ?unitLabel . }
OPTIONAL { ?f_featureKind mms:allowMultiple ?allowMultiple . }
OPTIONAL { ?f_featureKind <http://www.linkedmodel.org/schema/dtype#hasMember> ?optionId .
?optionId <http://www.linkedmodel.org/schema/dtype#value> ?optionValue .
OPTIONAL { ?optionId s:description ?optionDescription . } }
FILTER ( ( ?f_featureKind IN ( mms:StringType, mms:BooleanType, mms:ReferenceType ) || ?class IN ( mms:NumericType, mms:EnumerationType ) ) ) }
FILTER ( !( ( BOUND( ?organizationId ) && BOUND( ?projectId ) ) ) ) }
I checked if maybe we were dropping the binding when creating the ArrayBindingSet, but that doesn't seem to be the case.
Any chance you can create a small dataset that returns results for quantityKind with 4.0.3 but not with 4.1.0-M1?
For the test this dataset was used and worked with 4.0.3, but not with 4.1.0-M1:
https://gist.github.com/maxstolze/87ce3b98b2c7d883c420f54d93ec38cf
I've made a test based on your query and data, but I'm not able to get a binding quantityKind on the main branch or on the develop branch. Could you take a look?
https://github.com/eclipse/rdf4j/pull/4042
As described the problem seems only to happen with GraphDB.
GraphDB 9.11.1 running on RDF4J 3.7.6 and system property org.eclipse.rdf4j.rio.binary.format_version = 1 to be able to use RDF4J 4
Issue still exists with GraphDB 10.0.0 (RDF4J 4.0,2). Tested after MR #4039
Issue still exists with GraphDB 10.0.0 (RDF4J 4.0,2). Tested after MR #4039
Could you help me out with some code so I can try to reproduce this? I'm on holiday for a couple of weeks, but I can take a look again when I'm back.
Sorry for the late reply. We found the problem and it was test data/query based.
There were no quantityKindLabel / unitLabel for the quantityKind / unit provided in the test data.
Making the labels OPTIONAL as well, solfed the problem:
...
OPTIONAL { ?f_featureKind mms:quantityKind ?quantityKind ;
mms:unit ?unit.
OPTIONAL {?quantityKind <http://www.w3.org/2000/01/rdf-schema#label> ?quantityKindLabel .}
OPTIONAL { ?unit <http://www.w3.org/2000/01/rdf-schema#label> ?unitLabel . } }
...