rdf4j
rdf4j copied to clipboard
GH-3910 Initialize MemValueFactory with common vocabulary
GitHub issue resolved: #3910
Briefly describe the changes proposed in this PR:
PR Author Checklist (see the contributor guidelines for more details):
- [ ] my pull request is self-contained
- [ ] I've added tests for the changes I made
- [ ] I've applied code formatting (you can use
mvn process-resourcesto format from the command line) - [ ] I've squashed my commits where necessary
- [ ] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change
Before
Benchmark Mode Cnt Score Error Units
GetStatementsBenchmark.getTypesAndLabels avgt 5 138.205 ± 3.405 ms/op
GetStatementsBenchmark.groupByLanguage avgt 5 0.395 ± 0.035 ms/op
GetStatementsBenchmark.groupByType avgt 5 5.550 ± 1.104 ms/op
Benchmark Mode Cnt Score Error Units
ClassBenchmarkEmpty.shacl avgt 5 35.333 ± 4.160 ms/op
ClassBenchmarkEmpty.shaclBulk avgt 5 23.326 ± 2.817 ms/op
After
Benchmark Mode Cnt Score Error Units
GetStatementsBenchmark.getTypesAndLabels avgt 5 124.814 ± 0.286 ms/op
GetStatementsBenchmark.groupByLanguage avgt 5 0.367 ± 0.001 ms/op
GetStatementsBenchmark.groupByType avgt 5 4.617 ± 0.436 ms/op
Benchmark Mode Cnt Score Error Units
ClassBenchmarkEmpty.shacl avgt 5 36.835 ± 1.774 ms/op
ClassBenchmarkEmpty.shaclBulk avgt 5 24.892 ± 1.110 ms/op
At the moment I haven't found any existing benchmarks that are improved in this branch. The changes are based on my WIP performance branch #3854. Fixing one bottle neck will often reveal another performance issue that was masked by the initial bottle neck, so that might be the case here too. That being said there are quite a few fixes in that branch that didn't end up making much of a difference.
Before
Benchmark (param) Mode Cnt Score Error Units
ReasoningBenchmark.forwardChainingSchemaCachingRDFSInferencer moreRdfs::12180 avgt 5 11.254 ± 0.163 ms/op
ReasoningBenchmark.forwardChainingSchemaCachingRDFSInferencer longChain::5803 avgt 5 8.083 ± 0.048 ms/op
ReasoningBenchmark.forwardChainingSchemaCachingRDFSInferencer medium::544 avgt 5 0.833 ± 0.003 ms/op
ReasoningBenchmark.forwardChainingSchemaCachingRDFSInferencer simple::152 avgt 5 0.470 ± 0.016 ms/op
After
Benchmark (param) Mode Cnt Score Error Units
ReasoningBenchmark.forwardChainingSchemaCachingRDFSInferencer moreRdfs::12180 avgt 5 10.517 ± 0.882 ms/op
ReasoningBenchmark.forwardChainingSchemaCachingRDFSInferencer longChain::5803 avgt 5 7.472 ± 0.511 ms/op
ReasoningBenchmark.forwardChainingSchemaCachingRDFSInferencer medium::544 avgt 5 0.800 ± 0.085 ms/op
ReasoningBenchmark.forwardChainingSchemaCachingRDFSInferencer simple::152 avgt 5 0.436 ± 0.033 ms/op
Marking as stale to indicate this has been inactive for a while, and we should consider closing it.