rdf4j icon indicating copy to clipboard operation
rdf4j copied to clipboard

GH-2524 : Added regex for handling inline binding expressions

Open Sanchit-Trivedi opened this issue 3 years ago • 3 comments

GitHub issue resolved: #2524

Briefly describe the changes proposed in this PR:

The handling of binding substitution fails for queries of the form select (func(?x) as ?y). For a binding x=foo the output is select (func('foo' as ?x) as ?y) when it should be select (func('foo') as ?y). The current code only works for select ?x ?y ?z type queries. Regex has been modified to ignore patterns that are preceded by 'as'.


PR Author Checklist (see the contributor guidelines for more details):

  • [x] my pull request is self-contained
  • [ ] I've added tests for the changes I made
  • [x] I've applied code formatting (you can use mvn process-resources to format from the command line)
  • [ ] I've squashed my commits where necessary
  • [x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

Sanchit-Trivedi avatar May 13 '22 16:05 Sanchit-Trivedi

I think you need to run formatting here again as well - looks like it's not happy with the formatting of the javadoc in this case.

Run: mvn process-resources

abrokenjester avatar May 14 '22 10:05 abrokenjester

Could you add some tests too?

hmottestad avatar May 15 '22 06:05 hmottestad

Marked this as stale to signal that the PR hasn't been active for a while and that we should consider closing it.

hmottestad avatar Jul 24 '22 07:07 hmottestad