rdf4j
rdf4j copied to clipboard
GH-3798 Prepare the FunctionCall and And operators.
GitHub issue resolved: #3798 Briefly describe the changes proposed in this PR:
Start precompiling the binary operators. Taking into account constant propagation.
PR Author Checklist (see the contributor guidelines for more details):
- [x] my pull request is self-contained
- [ ] I've added tests for the changes I made
- [x] I've applied code formatting (you can use
mvn process-resources
to format from the command line) - [ ] I've squashed my commits where necessary
- [X] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change
This is a draft pull request, as I want to do one commit per operator and probably want to move some code out of the very large StrictEvaluationStrategy class.
@JervenBolleman is this PR ready to merge?
I need to double check the merge but otherwise this was ready to go.
@JervenBolleman this has been sitting for a while now - is all that's needed a rebase before it's ready to merge?
I rebased it and I think it is ready for a merge.
@JervenBolleman I'm sorry that we have to keep doing this, but it seems we missed the window to merge this, and it now has several conflicts again. Do you think you have time to try and resolve this? Would be ace if we could get this merged before a 4.3 release...
@abrokenjester no, problem :) I had actually done the work last night. Just had to check that mvn verify had passed this morning.