org.eclipse.rap icon indicating copy to clipboard operation
org.eclipse.rap copied to clipboard

Export all packages from org.eclipse.rap.nebula.jface.gridviewer

Open kysmith-csg opened this issue 1 year ago • 2 comments
trafficstars

Makes sure all packages (for now, just a single internal one) is exported from org.eclipse.rap.nebula.jface.gridviewer. Marked as x-internal so clients receive warnings when importing them. See upstream Nebula here: https://github.com/eclipse/nebula/blob/master/widgets/grid/org.eclipse.nebula.widgets.grid/META-INF/MANIFEST.MF#L10 (they combined the gridviewer bundle into the grid bundle but the package name is the same).

kysmith-csg avatar Jun 20 '24 16:06 kysmith-csg

Can one of the admins verify this patch?

eclipse-rap-bot avatar Jun 20 '24 16:06 eclipse-rap-bot

ok to test

mknauer avatar Jun 21 '24 14:06 mknauer

Please update the PR to the current state of RAP main branch.

ifurnadjiev avatar Aug 20 '24 09:08 ifurnadjiev

@ifurnadjiev merged

kysmith-csg avatar Aug 20 '24 12:08 kysmith-csg

ok to test

ifurnadjiev avatar Aug 20 '24 12:08 ifurnadjiev

@kysmith-csg Please rebase your old two commits on RAP main branch and force push the branch. It still shows that the PR can not be merged due to conflicts.

ifurnadjiev avatar Aug 20 '24 13:08 ifurnadjiev

@ifurnadjiev sorry about that, should be all set now.

kysmith-csg avatar Aug 20 '24 13:08 kysmith-csg