eclipse.platform icon indicating copy to clipboard operation
eclipse.platform copied to clipboard

Deduplicate stored launch configs of nested projects #798

Open Bananeweizen opened this issue 2 years ago • 4 comments

Fixes #798.

m2e projects can be nested (e.g. modules stored inside a reactor). Launch configs stored the inner nested projects appear twice, because they are not equal with the old implementation checking only name and container. Therefore also check the resolved location if the containers are different.

I've tested this with an m2e IDE containing such nested projects and stored launch configs. The duplicates are gone with the change.

Bananeweizen avatar Nov 11 '23 15:11 Bananeweizen

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 39m 0s :stopwatch: + 14m 36s  3 981 tests ±0   3 958 :white_check_mark:  - 1   22 :zzz: ±0  1 :x: +1  12 540 runs  ±0  12 373 :white_check_mark:  - 3  164 :zzz: ±0  3 :x: +3 

For more details on these failures, see this check.

Results for commit a742866a. ± Comparison against base commit 6d514be2.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Nov 11 '23 15:11 github-actions[bot]

@Bananeweizen master is open do you like to finish this?

laeubi avatar Nov 30 '23 06:11 laeubi

@Bananeweizen Can you take this to closure?

SarikaSinha avatar Feb 12 '24 06:02 SarikaSinha