eclipse.platform Stored launch configs of nested projects shown twice

If projects are nested (which is typical for maven reactor and modules), then launch configs stored in the nested project are shown twice in the run drop down. It might be useful to implement equals/hashCode such that the absolute file system paths are compared (or to alternatively filter based on the absolute file system path).

grafik

Nov 01 '23 10:11 Bananeweizen

@mickaelistria can you please look into all those duplicate launch config issues.

Nov 02 '23 07:11 jukzi

@jukzi this is a completely different menu so not related to https://github.com/eclipse-platform/eclipse.platform/issues/527

@Bananeweizen can you please explain from what Eclipse version this is a regression?

Nov 02 '23 07:11 laeubi

@laeubi I'm not sure that this is a regression. I think it has always been that way. https://github.com/eclipse-platform/eclipse.platform/blame/9802acd4bfbe3995960cfaafd713c76fc1ceda74/debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/LaunchConfiguration.java#L372 is unchanged since 15 years and that location comparison leads to projectA/project/B/C.launch not being considered the same as projectB/C.launch.

Nov 02 '23 15:11 Bananeweizen