eclipse.platform icon indicating copy to clipboard operation
eclipse.platform copied to clipboard

Unable to see effect when clicking on some of the Eclipse toolbar icons when using dark mode in Eclipse

Open marioja opened this issue 2 years ago • 2 comments

I am using eclipse 2023-03 on a Windows 10 computer. Windows is using dark mode and Eclipse is using the Dark theme and the Default color and font theme. I have added a Tomcat 10 server and I am looking at the console window for this server.

When I click on any of those buttons (I did not test them all) I see a slight (maybe 1 pixel) displacement but there is no discernable change:

  • Scroll Lock
  • Show Console When Standard Out Changes
  • Show Console When Standard Error changes

Here is the screenshot with state 1 (cannot tell if pressed or not): state1 Here is the screenshot with state 2: state2 I changed the state for the eighth and ninth icons (Show Console When... buttons) and if you can tell them apart, you are amazing!

Before a fix is produced, since it will be in the latest release and not this one, any information as to a workaround to change some settings would be extremely useful to apply to existing installation since not everyone is capable to moving to the latest nightly build.

The problem occurs on the Team History view also and probably on most other toolbars.

marioja avatar Aug 04 '23 15:08 marioja

I noticed that in Eclipse 2023-06 the bug has been fixed. Here is the history view from 2023-03 with the second icon (Link with Editor and Selection) clicked: history 2023-03 Here is the same with Eclipse 2023-06: history 2023-06 As I said previously, I am stuck with 2023-03 for the time being due to a plugin availability. I searched the git history, the bug database, the 2023-06 release notes and for the life of me I could not find out what change fixed this. I would appreciate if someone could help in pointing to the git commit number as well as a suggestion on how to apply this to 2023-03.

marioja avatar Aug 08 '23 12:08 marioja

Might be this one https://github.com/eclipse-platform/eclipse.platform.swt/commit/fbd70cd1cce60500699938e8525a3f345bd4dc70

Phillipus avatar Aug 09 '23 06:08 Phillipus