Help: Titles of some sections in the Help view are black also when using the dark theme

[fedejeanne]

Describe the bug Titles are black and can't be seen in the black background.

Affects at least "See also" and "More results" titles in the context-aware help information.

To Reproduce

• Activate the Dark theme
• Open the Help (F1)

Expected behavior The title should be in white (or is it gray?) like the text above it.

Screenshots

Environment:

1. Select the platform(s) on which the behavior is seen:

• • [ ] All OS
• • [x] Windows
• • [ ] Linux
• • [x] macOS

[HeikoKlare]

Isn't this an issue of the shown web page / its CSS styling rather than Edge itself?

[fedejeanne]

Could be, I haven't looked into it yet.

[HeikoKlare]

Also happens in MacOS/WebKit:

It's related to the context-aware help in an RCP, so nothing related to the About page of Java editor. Thus moving to Platform.

[vogella]

Adding @BeckerWdf who worked on help styling in the past IIRC

[fedejeanne]

I'm debugging ContextHelperPart::addCategory and I see that the resulting HTML is

<p><span color="org.eclipse.ui.forms.TITLE">See also:</span></p>

Deleting the color attribute in the span does the trick, but that would mean I have to delete it from other places too. I would like to be able to set the color for org.eclipse.ui.forms.TITLE instead, I just can't find the way to do it.

I tried adding this to e4-dark_ide_colorextensions.css

ColorDefinition#org.eclipse.ui.forms.TITLE {
	color: #eeeeee;
	category: '#org-eclipse-ui-presentation-default';
	label: url('platform:/plugin/org.eclipse.ui.themes?message=TITLE');
}

and I also tried using - instead of . i.e.

ColorDefinition#org-eclipse-ui-forms-TITLE {
	color: #eeeeee;
	category: '#org-eclipse-ui-presentation-default';
	label: url('platform:/plugin/org.eclipse.ui.themes?message=TITLE');
}

But it doesn't work. I see absolutely no difference in the output.

Any hints?

[tomaswolf]

Perhaps it needs to be listed in the ThemesExtension block before the color definitions?