eclipse.platform icon indicating copy to clipboard operation
eclipse.platform copied to clipboard

Marked long-time deprecated API in Plugin for removal

Open vogella opened this issue 7 months ago • 3 comments

Plugin contains methods which are marked since a long time as deprecated. Marking these for removal to give us the flexibility to remove these after API freeze period if needed.

Triggered by an investigation of ILegacyPreferences from Equinox which calls some of these methods in PreferenceServiceRegistryHelper during startup.

vogella avatar May 09 '25 10:05 vogella

This pull request changes some projects for the first time in this development cycle. Therefore the following files need a version increment:

runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 79f240ae2a905c490e20723551b593e4386d39e1 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Fri, 9 May 2025 10:15:58 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
index d7ec81e54a..ed76b75691 100644
--- a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
+++ b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
-Bundle-Version: 3.33.0.qualifier
+Bundle-Version: 3.33.100.qualifier
 Bundle-SymbolicName: org.eclipse.core.runtime; singleton:=true
 Bundle-Vendor: %providerName
 Bundle-Activator: org.eclipse.core.internal.runtime.PlatformActivator
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

eclipse-platform-bot avatar May 09 '25 10:05 eclipse-platform-bot

Test Results

 1 764 files  ±0   1 764 suites  ±0   1h 28m 13s ⏱️ - 17m 44s  4 381 tests ±0   4 356 ✅ ±0   24 💤 ±0  1 ❌ ±0  13 143 runs  ±0  12 975 ✅ ±0  167 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 4fbedd6c. ± Comparison against base commit 2e1aceed.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 09 '25 10:05 github-actions[bot]

the preference API is still used by Ant.... So this should be updated to not mark this API for deletion as I assume no one plans to work on updating Ant to the non-deprecated preferences.

vogella avatar May 09 '25 11:05 vogella

the preference API is still used by Ant.... So this should be updated to not mark this API for deletion as I assume no one plans to work on updating Ant to the non-deprecated preferences.

Would it be difficult to migrate away from the old API in Eclipse-ANT?

I don't know, never looked into this. In my more active time Ant was heavily "guarded" by others so it never felt like worth trying to invest into this code.

vogella avatar May 16 '25 06:05 vogella

The test failure 1 out of 3 runs failed: testBug546710_ConsoleCreationRaceCondition (org.eclipse.debug.tests.console.ProcessConsoleManagerTests in Windows seems unrelated.

vogella avatar May 16 '25 09:05 vogella

the preference API is still used by Ant.... So this should be updated to not mark this API for deletion as I assume no one plans to work on updating Ant to the non-deprecated preferences.

It's really quite widely used beyond just Ant, including by other methods that return a deprecated Preferences instance.

image

merks avatar May 18 '25 06:05 merks