eclipse.platform icon indicating copy to clipboard operation
eclipse.platform copied to clipboard

Additional Separator

Open SougandhS opened this issue 1 year ago • 6 comments

This PR provides additional separation and arrangements between Enable/Disable Actions in breakpoints view. New actions can be contributed here.

Part of Enhancement #https://github.com/eclipse-jdt/eclipse.jdt.debug/pull/550

SougandhS avatar Dec 02 '24 02:12 SougandhS

Hi @iloveeclipse , pls check this additional separator for https://github.com/eclipse-jdt/eclipse.jdt.debug/pull/550#discussion_r1821134231

SougandhS avatar Dec 02 '24 02:12 SougandhS

Test Results

 1 668 files   -    87   1 668 suites   - 87   1h 14m 39s ⏱️ - 11m 32s  3 573 tests  -   597   3 552 ✅  -   595   21 💤  - 1  0 ❌  - 1  11 316 runs   - 1 791  11 157 ✅  - 1 785  159 💤  - 5  0 ❌  - 1 

Results for commit aa485f30. ± Comparison against base commit 3f7070ea.

This pull request removes 597 tests.
AllTests ApiDocTest ‑ testTopicsReference
AllTests LinkTest ‑ testAllLinks
AllTests TocLinkChecker ‑ testJdtIsvGenerated
AllTests TocLinkChecker ‑ testJdtIsvStatic
AllTests TocLinkChecker ‑ testJdtUser
AllTests TocLinkChecker ‑ testPdeUserGenerated
AllTests TocLinkChecker ‑ testPdeUserStatic
AllTests TocLinkChecker ‑ testPlatformIsvGenerated
AllTests TocLinkChecker ‑ testPlatformIsvStatic
AllTests TocLinkChecker ‑ testPlatformUser
…

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Dec 02 '24 02:12 github-actions[bot]

please post before/after screenshot

jukzi avatar Dec 04 '24 13:12 jukzi

eclipse-jdt/eclipse.jdt.debug#550 (comment)

As of now visually it doesn't make difference

before - image

after - image

But this will help in arranging a new option in the proper position https://github.com/eclipse-jdt/eclipse.jdt.debug/pull/550#discussion_r1860011629 391035940-c62fc2be-7a87-4c44-8ba8-0dfaa292b9e6

SougandhS avatar Dec 04 '24 14:12 SougandhS

Build fails with missing version increment:

13:48:30.402 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.10:verify (verify) on project org.eclipse.debug.ui: There are API errors:
13:48:30.402 [ERROR] META-INF/MANIFEST.MF:5 The minor version should be incremented in version 3.18.700, since new APIs have been added since version 3.18.600
13:48:30.402 [ERROR] -> [Help 1]

jukzi avatar Dec 04 '24 14:12 jukzi

Build fails with missing version increment:

13:48:30.402 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.10:verify (verify) on project org.eclipse.debug.ui: There are API errors:
13:48:30.402 [ERROR] META-INF/MANIFEST.MF:5 The minor version should be incremented in version 3.18.700, since new APIs have been added since version 3.18.600
13:48:30.402 [ERROR] -> [Help 1]

will do a version bump

SougandhS avatar Dec 04 '24 14:12 SougandhS