eclipse-platform
Avoid duplicated IFileInfo fetches when creating resources
@jukzi I assume this didn't show up in your recent performance analysis of the resources handling so I assume it won't have a big impact, but avoiding subsequent duplicated file-fetches is probably still beneficial.
Test Results
1 758 files ±0 1 758 suites ±0 1h 31m 14s ⏱️ + 2m 1s 4 170 tests ±0 4 148 ✅ ±0 22 💤 ±0 0 ❌ ±0 13 107 runs ±0 12 943 ✅ ±0 164 💤 ±0 0 ❌ ±0
Results for commit 6bfdd8c9. ± Comparison against base commit 93a2f4b0.
:recycle: This comment has been updated with latest results.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Isn't that intended extra check for case insensitive file systems?
Where exactly? And how does it help to fetch the info of the same store twice? Sorry if I missed that discussion.
No, I just wondered that this extra check was behind extra "if" condition for case insensitive file systems. May be that is not a mistake but intention. I would check in git blame when it was added, for sure it is something Windows specific.