eclipse.platform icon indicating copy to clipboard operation
eclipse.platform copied to clipboard

[FileSystem] Simplify and modernize NativeHandlers

Open HannesWell opened this issue 1 year ago • 5 comments

HannesWell avatar Jun 22 '24 20:06 HannesWell

Test Results

 1 734 files  ±0   1 734 suites  ±0   1h 26m 47s :stopwatch: + 2m 2s  3 971 tests ±0   3 949 :white_check_mark: ±0   22 :zzz: ±0  0 :x: ±0  12 510 runs  ±0  12 349 :white_check_mark: ±0  161 :zzz: ±0  0 :x: ±0 

Results for commit c868e155. ± Comparison against base commit 6f2754b4.

github-actions[bot] avatar Jun 22 '24 20:06 github-actions[bot]

I'll have a look at the tests.

i don't even get why Path.of() should be any better.

Paths.get() was only introduced because back then static methods on interfaces were not supported. When it was possible Path.of was added, as a method that is easier to discover/remember/read. And since both are technical equal I don't see a reason to not use it.

HannesWell avatar Jun 24 '24 20:06 HannesWell

And since both are technical equal I don't see a reason to not use it.

I would also use Path for new code, but is it worth to enlarge the git history with rewriting it?

jukzi avatar Jun 25 '24 14:06 jukzi

I would also use Path for new code, but is it worth to enlarge the git history with rewriting it?

As the PR is not just about that and what is questioned removes one useless method call from the chain - it is worth it.

akurtakov avatar Jun 25 '24 14:06 akurtakov