eclipse.platform icon indicating copy to clipboard operation
eclipse.platform copied to clipboard

[19+] fix warning about Thread.getID()

Open jukzi opened this issue 1 year ago • 1 comments

'The method getId() from the type Thread is deprecated since version 19'

jukzi avatar Jun 04 '24 10:06 jukzi

Test Results

 1 755 files  ±0   1 755 suites  ±0   1h 42m 25s ⏱️ + 4m 40s  4 170 tests ±0   4 148 ✅ ±0   22 💤 ±0  0 ❌ ±0  13 107 runs  ±0  12 943 ✅ ±0  164 💤 ±0  0 ❌ ±0 

Results for commit 65ccae14. ± Comparison against base commit 023ee353.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 04 '24 10:06 github-actions[bot]

As this is tests code it's fine to bump its BREE to 21 and land this one in. We already struggle with maintaining the PR queue so better to not have such as this one lurking around.

akurtakov avatar Jan 13 '25 11:01 akurtakov

As this is tests code it's fine to bump its BREE to 21

ok if i just bump all tests?

jukzi avatar Jan 13 '25 12:01 jukzi

I don't mind moving to Java 21 but mass moves tend to make things go unnoticed (e.g. many new warnings at once) .

akurtakov avatar Jan 13 '25 12:01 akurtakov

Another thing to consider is that moving tests to Java 21 makes it harder to test bundles against Java 17 if the bundle under test is still on Java 17.

akurtakov avatar Jan 13 '25 12:01 akurtakov