eclipse.platform icon indicating copy to clipboard operation
eclipse.platform copied to clipboard

Selection with custom line spacing only pads on the bottom, not the top

Open gnaatz opened this issue 1 year ago • 2 comments

When selecting a custom line spacing (Settings -> General-> Editors -> Text Editors -> Line spacing) and selecting a line in an editor, the selection is only padded to the bottom but not the top. This makes for an awkward feel and does not seem to be expected. I do not know, whether the behaviour changed anytime before or whether this always was the case.

It would be expected for the line spacing to be equal on top an bottom when having a line highlighted.

This happens on the newest build on Mac.

Screenshots: This is where the setting is located: Screenshot 2024-05-28 at 11 08 55

This is the current situation: Screenshot 2024-05-28 at 11 10 47 I would expect the padding of the line select to be equidistant from the text on top and bottom.

(This might be considered an enhancement, but I do believe this is not intentional in the first place)

gnaatz avatar May 27 '24 09:05 gnaatz

@gnaatz, thank you for your report. Could you please provide a screenshot of such text selection and of the exact preference you are referring to, because at least under Windows I can't find that exact preference. Please also provide the versions of Eclipse until it was working as expected and since when it started to look differently.

Furthermore I assume, although the preference is probably implemented in this repo, actual implementation is in SWT. So depending on what has changed exactly, this issue maybe will be transferred to SWT by us (but this isn't a problem for now).

HannesWell avatar May 27 '24 22:05 HannesWell

Linking SWT Issue i found (by chance): https://github.com/eclipse-platform/eclipse.platform.swt/issues/1286

gnaatz avatar Jul 11 '24 08:07 gnaatz