eclipse.platform icon indicating copy to clipboard operation
eclipse.platform copied to clipboard

Fix "Terminate and Relaunch" of groups that use adoptIfRunning #1318

Open jukzi opened this issue 1 year ago • 1 comments

This was a race condition: RuntimeProcess.fTerminated was only set asynchronously, hindering relaunching the process, thinking it was already running.

Happened only for GroupLaunchElement.adoptIfRunning == true

fixes https://github.com/eclipse-platform/eclipse.platform/issues/1318

jukzi avatar May 17 '24 07:05 jukzi

Test Results

 1 737 files  ±0   1 737 suites  ±0   1h 27m 31s :stopwatch: - 13m 14s  3 972 tests ±0   3 949 :white_check_mark:  - 1   22 :zzz: ±0  1 :x: +1  12 513 runs  ±0  12 351 :white_check_mark:  - 1  161 :zzz: ±0  1 :x: +1 

For more details on these failures, see this check.

Results for commit faf27df4. ± Comparison against base commit a4776c2a.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 17 '24 08:05 github-actions[bot]

ignoring unrelated random fail ProcessConsoleManagerTests

jukzi avatar Jun 06 '24 13:06 jukzi