eclipse.platform icon indicating copy to clipboard operation
eclipse.platform copied to clipboard

Add a case sensitive variant of IContentType.isAssociatedWith #673

Open jantje opened this issue 1 year ago • 3 comments

As discussed in #673 Would something like this be acceptable? I could not test the change so I do not know this will work yet so please do not yet accept this. What is the advised way to add tests?

jantje avatar Mar 04 '24 22:03 jantje

Test Results

  424 files   -   212    424 suites   - 212   29m 14s :stopwatch: - 10m 46s 3 945 tests ±    0  3 904 :white_check_mark:  -    18   41 :zzz: +18  0 :x: ±0  8 294 runs   - 4 147  8 179 :white_check_mark:  - 4 098  115 :zzz:  - 49  0 :x: ±0 

Results for commit 9b1f3c04. ± Comparison against base commit 31e1ef4f.

This pull request skips 18 tests.
org.eclipse.core.tests.resources.regression.Bug_026294 ‑ testDeleteClosedProjectLinux
org.eclipse.core.tests.resources.regression.Bug_026294 ‑ testDeleteFolderLinux
org.eclipse.core.tests.resources.regression.Bug_026294 ‑ testDeleteOpenProjectLinux
org.eclipse.core.tests.resources.regression.Bug_044106 ‑ testDeleteLinkedFile
org.eclipse.core.tests.resources.regression.Bug_044106 ‑ testDeleteLinkedFileKeepHistory
org.eclipse.core.tests.resources.regression.Bug_044106 ‑ testDeleteLinkedFolder
org.eclipse.core.tests.resources.regression.Bug_044106 ‑ testDeleteLinkedFolderKeepHistory
org.eclipse.core.tests.resources.regression.Bug_044106 ‑ testDeleteLinkedFolderParentKeepHistory
org.eclipse.core.tests.resources.regression.Bug_044106 ‑ testDeleteLinkedResourceInProject
org.eclipse.core.tests.resources.regression.Bug_044106 ‑ testDeleteLinkedResourceInProjectKeepHistory
…

github-actions[bot] avatar Mar 08 '24 13:03 github-actions[bot]

What would be responsible of defining whether we want caseStrict or not? Some global preference? A flag in the extension point?

mickaelistria avatar Aug 15 '24 06:08 mickaelistria

What would be responsible of defining whether we want caseStrict or not? Some global preference? A flag in the extension point?

That's also a very good question! I see these callers:

image image

But that's mostly in the type hierarchy. It's not at all clear how the following usage would decide true versus false and in fact there isn't good non-deprecated method for it to call:

image

I would have expect the flag to be defined by the content type provider/definition such that this decision is not even something you see in the API. I.e., just because CDT wants .c and .C to be the same, doesn't mean JDT should also .Java, .JaVa, and all variations there of...

merks avatar Aug 15 '24 06:08 merks