Mark several unused deprecated methods/constants/classes in org.eclipse.jface package for removal
Test Results
3 018 files ±0 3 018 suites ±0 2h 8m 52s ⏱️ - 3m 48s 8 242 tests ±0 7 994 ✅ +1 248 💤 ±0 0 ❌ - 1 23 646 runs ±0 22 855 ✅ +1 791 💤 ±0 0 ❌ - 1
Results for commit ecf7a1e0. ± Comparison against base commit 26ddd0da.
:recycle: This comment has been updated with latest results.
@merks Could you take a look at this when you get some time please.
@merks Can you take a look at this when you get some time please.
@merks can you see if the change is not good for you? @deepika-u can you re-trigger the build?
I wanted to make a general point here as well. If you mark something for removal, please ensure you have the full SDK IDE setup and that you look at the call hierarchy of each and every field, method, or class you plan to mark for deletion. If you find even one use of it, you can assume that you will find 1000 uses of it out there in the ecosystem such that if you delete that thing, there will be things that simply stop working. Then you should ask yourself, is there significant value in the removal that offsets the broken functionality downstream, keeping in mind that any broken functionality in any IDE for any component will generally create a bad impression overall; one that generally comes back to roost in the Platform. Is it worth it?
Especially at least Platform itself must be free from any references first, as otherwise builds in the sub repositories will start to fail!
If i run this QuickAccessComputerTest locally, with and without pr - in both cases test is passing.
If i run locally the ProgressContantsTest, all the tests are passing locally with and without the pr.
1 out of 3 runs failed: testBinaryContentTypeWithDescriberParallel (AllSearchTests AllFileSearchTests FileSearchTests) is known to be flaky. I have a look.
1 out of 3 runs failed: testBinaryContentTypeWithDescriberParallel (AllSearchTests AllFileSearchTests FileSearchTests) is known to be flaky. I have a look.
Thanks for your input.
@merks : can you take a look at this once you get some time please?