Upstream fixed ScopedPreferenceStore from XText

[pazi146]

Let's make sure issue is not already fixed in latest builds first.

• [x] I verified latest Integration Build of Eclipse SDK doesn't provide the feature.

Suggestion

Upstream the changes in FixedScopedPreferenceStore (Xtext) to ScopedPreferenceStore to fix the memory leak

old bugs: https://bugs.eclipse.org/bugs/show_bug.cgi?id=239033 https://bugs.eclipse.org/bugs/show_bug.cgi?id=362199

Relevant change: The handling of the INodeChangeListener is changed to be the same as the IPreferenceChangeListener (which fixes the memory leak)

What would be the steps to upstream this change with the proper attribution?

Community

• [x] I understand suggesting an enhancement doesn't mandate anyone to implement it. Other contributors may consider this suggestion, or not, at their own convenience. The most efficient way to get it fixed is that I implement it myself and contribute it back as a good quality patch to the project.

[iloveeclipse]

For the reference: https://github.com/eclipse-xtext/xtext/commit/e6ebfc52bc16f24d978a90f3c3f64c0a7b135c92

@pazi146 : do you plan to work on it?

[pazi146]

@iloveeclipse the work is already done - I can make a pull request but I'm not sure how to properly attribute the work (or if I'm even allowed to do that with someone else's work)

[iloveeclipse]

I'm not sure how to properly attribute the work (or if I'm even allowed to do that with someone else's work)

If I read it right, the work was done by @szarnekow via https://github.com/eclipse-xtext/xtext/commit/e6ebfc52bc16f24d978a90f3c3f64c0a7b135c92.

1. The code is under EPL, so sure you can contribute it to platform.
2. You can add @szarnekow mail via Also-By: line in the git commit message (see https://www.eclipse.org/projects/handbook/#resources-commit)

[pazi146]

Thank you for the info