eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

Reduce gradients usage in new Wizard

Open vogella opened this issue 10 months ago • 9 comments

I think the gradients in our wizard look bad and I suggest we reduce the usage of them.

Image

IIRC I also saw a statement from @Michael5601 that this would also be faster, once his SVG support is implemented and used.

So IMHO without the gradients the wizard would look nicer and if upcoming SVG they would also faster to be loaded.

For an example without gradient, looks at the Maven wizards:

Image

@BeckerWdf WDYT?

vogella avatar Jan 17 '25 09:01 vogella

See also https://github.com/eclipse-platform/eclipse.platform.ui/issues/2721

vogella avatar Jan 17 '25 09:01 vogella

It looks bad that the image touches the top. Is that related or just somewhat poor icon design?

merks avatar Jan 17 '25 09:01 merks

These wizard icons are all very detailed. I think this is due to the larger size in which they are presented compared to all other icons. I am also in favor of simplifying them and this is also my opinion for all other icons too. But for the wizard icons alone we won't see a significant performance improvement when using SVGs as they only have limited usage.

Michael5601 avatar Jan 17 '25 09:01 Michael5601

It looks bad that the image touches the top. Is that related or just somewhat poor icon design?

I think it is the icon design. Of course you can define a icon without gradients without starting at the top.

vogella avatar Jan 17 '25 21:01 vogella

For an example without gradient, looks at the Maven wizards

This icon anyway does not comply to the current eclipse style guide. Even if we don't like the current style we should stick to it so that the application looks consistent...

BeckerWdf avatar Jan 18 '25 14:01 BeckerWdf

Please link to the corresponding style guide section

vogella avatar Jan 18 '25 15:01 vogella

I'm not sure where this lives now:

https://www.eclipse.org/articles/Article-UI-Guidelines/Contents.html#WizSpecsSize_VDG

merks avatar Jan 18 '25 16:01 merks

I'm not sure where this lives now

Source: https://github.com/eclipse-platform/ui-best-practices Deployed: https://eclipse-platform.github.io/ui-best-practices/

laeubi avatar Jan 18 '25 16:01 laeubi

I'm not sure where this lives now:

https://www.eclipse.org/articles/Article-UI-Guidelines/Contents.html#WizSpecsSize_VDG

Thanks Ed. I think the new link is https://eclipse-platform.github.io/ui-best-practices/#wizard_banner_graphics

vogella avatar Feb 05 '25 10:02 vogella