Selected icons in toolbar look white in the dark theme

[vogella]

Toolbar buttons which are selected are incorrectly styled in the dark theme under Windows.

@mvm-sap can you have a look?

[mvm-sap]

@vogella What is the expected style for the selected toolbar buttons?

[vogella]

Not sure what the SWT offers under windows but a dark background would be nice

[vogella]

On Linux it looks good:

[mikevwdriver]

@vogella Can you please post screenshots from Windows? I just ran the latest I-Build on Windows and did not observe any improvement in this area.

[vogella]

See first entry. The second one is from Linux

[MikeMCrank]

With some changes to Win32 SWT, it's possible to get control over the color used for the ToolBar Items.

Before:

After:

With Hover: Before:

After:

Presently I'm uncertain what the best way to source/configure the colors are. Currently It's using the following two colors: Hover - OS.COLOR_BTNSHADOW Selected - OS.COLOR_GRAYTEXT

[MikeMCrank]

I did a bit more work in this area, specifically for Drop Down items which were styled differently when hot.

Before:

After:

You'll notice that the non-hot icons have also changed as well to a lighter colored triangle (which is really helpful for darker themes)

It works by doing some custom draw handling and I've written it so that it's essentially producing pixel-perfect results in 100%,150%,200% dpi/zoom levels.

[MikeMCrank]

I've also taken some time to get toolbar buttons with text to render correctly: Before:

After:

The original problem was mentioned in eclipse-platform/eclipse.platform.swt#1696

[MikeMCrank]

It's worth noting that we have the complete flexibility to change the presentation here.

For example, matching MacOS dark theme:

In Windows:

[MikeMCrank]

I suppose we may need to move this issue into the SWT repository: https://github.com/eclipse-platform/eclipse.platform.swt