eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard
verified publisher icon eclipse-platform

Modify the 'Close Active Editors' (plural) handler to add support for…

Open feilimb opened this issue 1 year ago • 4 comments

Modify the 'Close Active Editors' (plural) handler to add support for parts which represent an Editor and have been contributed via eg. PartDescriptors in a Model Fragment.

See also, the recent and similar PR: https://github.com/eclipse-platform/eclipse.platform.ui/pull/2315

Associated with Issue#2176.

@mickaelistria - just tagging you here since you were good enough to review the other related PR recently (2315).

feilimb avatar Oct 03 '24 13:10 feilimb

Test Results

 1 821 files  +3   1 821 suites  +3   1h 38m 48s :stopwatch: - 1m 9s  7 709 tests +1   7 481 :white_check_mark: +1  228 :zzz: ±0  0 :x: ±0  24 288 runs  +3  23 541 :white_check_mark: +3  747 :zzz: ±0  0 :x: ±0 

Results for commit 0174c8fd. ± Comparison against base commit 83bf6708.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 03 '24 13:10 github-actions[bot]

Can you please add a junit test?

referenced issue: https://github.com/eclipse-platform/eclipse.platform.ui/issues/2176

jukzi avatar Oct 08 '24 14:10 jukzi

Can you please add a junit test?

@jukzi Certainly I can try - would there any pre-existing tests in the area of editor opening/closing (ideally compatibility layer plus E4 part descriptor fragment contribution) that you could point me towards as a starting point of reference?

feilimb avatar Oct 08 '24 16:10 feilimb

sorry i am not familiar with e4, but you may look around in package org.eclipse.ui.tests.e4;

jukzi avatar Oct 08 '24 16:10 jukzi

@jukzi JUnit test added now, hopefully it is sufficient for what needs to be covered

feilimb avatar Oct 10 '24 11:10 feilimb

Code style & copyright block changes applied, hopefully I caught everything there.

feilimb avatar Oct 10 '24 13:10 feilimb

Merged all commits into one, and rebased branch - to see if the Workflows fare better.

feilimb avatar Oct 10 '24 15:10 feilimb

LGTM, lets wait a bit if someone else wants to review / test

@jukzi there has been no more inputs on this PR in the meantime, do you think it would be possible to land it at this point?

feilimb avatar Oct 22 '24 10:10 feilimb

New test seems to be unstable failed (at least):

  • https://download.eclipse.org/eclipse/downloads/drops4/I20241022-1800/testresults/html/org.eclipse.ui.tests_ep434I-unit-cen64-gtk3-java23_linux.gtk.x86_64_23.html
  • https://download.eclipse.org/eclipse/downloads/drops4/I20241022-1800/testresults/html/org.eclipse.ui.tests_ep434I-unit-cen64-gtk3-java17_linux.gtk.x86_64_17.html

akurtakov avatar Oct 23 '24 05:10 akurtakov