eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

Light (Preview) theme: Change to bg color of vertical bar in editor

Open mvm-sap opened this issue 1 year ago • 1 comments

Vertical bar next to the scroll bar in editor had white background color. This has been reverted to grey. Refer issue #2201 . Find screen shots below, captured in win os.

Before: image

After: image

mvm-sap avatar Sep 23 '24 11:09 mvm-sap

Test Results

 1 818 files  +  3   1 818 suites  +3   1h 32m 47s :stopwatch: + 8m 25s  7 709 tests + 45   7 481 :white_check_mark: +155  228 :zzz: ± 0  0 :x:  - 1  24 288 runs  +128  23 541 :white_check_mark: +441  747 :zzz: +22  0 :x:  - 1 

Results for commit 649381b7. ± Comparison against base commit 1eead54a.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 23 '24 17:09 github-actions[bot]

@mvm-sap: Can you please. rebase and resolve the merge conflicts?

BeckerWdf avatar Oct 11 '24 08:10 BeckerWdf

@mvm-sap: Can you please. rebase and resolve the merge conflicts?

I have resolved merge conflicts

mvm-sap avatar Oct 15 '24 06:10 mvm-sap

What is the current plan for the preview? Will it become default for the 2024-12 release?

vogella avatar Oct 15 '24 06:10 vogella

pr-head fails. I see this in the log:

Recording test results
No test report files were found. Configuration error?
Error when executing always post condition:
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from 10.40.69.236/10.40.69.236:59068

Is this an infrastructure issue? Can we anyway merge this PR?

BeckerWdf avatar Oct 15 '24 07:10 BeckerWdf