eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

Problem view filtering through FiltersConfigurationDialog could be made part of the API

Open eobrienPilz opened this issue 1 year ago • 0 comments

FiltersConfigurationDialog and many associated classes are public but unfortunately also internal. Many of these can be used by clients, however there is a risk that they may can be changed or removed in future platform releases.

Some background to this enhancement suggestion.

Customization of the filtering functionality has been very useful for us in our Eclipse RCP client application. Additionally, we've had some Platform API changes merged which have allowed us to remove reflection from our client code.

Related pull requests

https://github.com/eclipse-platform/eclipse.platform.ui/pull/17 https://github.com/eclipse-platform/eclipse.platform.ui/pull/84 https://github.com/eclipse-platform/eclipse.platform.ui/pull/87 https://github.com/eclipse-platform/eclipse.platform.ui/pull/348

It seems reasonable that others would also find this functionality useful at an API level.

The enhancement suggestion.

These classes or a subset found in the package org.eclipse.ui.internal.views.markers could be moved out of the internal namespace. This is a list of the classes that we use and would like to see made part of the API. There may be others that could also be included.

org.eclipse.ui.internal.views.markers.FiltersConfigurationDialog; org.eclipse.ui.internal.views.markers.MarkerContentGenerator; org.eclipse.ui.internal.views.markers.ScopeArea; org.eclipse.ui.views.markers.internal.MarkerMessages; org.eclipse.ui.internal.views.markers.ExtendedMarkersView org.eclipse.ui.internal.views.markers.ConfigureContentsDialogHandler org.eclipse.ui.internal.views.markers.MarkerFieldFilterGroup org.eclipse.ui.internal.views.markers.ProblemsSeverityAndDescriptionFieldFilter org.eclipse.ui.internal.views.markers.ProblemsSeverityAndDescriptionConfigurationArea org.eclipse.ui.internal.views.markers.MarkerTypeFieldFilter org.eclipse.ui.internal.views.markers.TypesConfigurationArea org.eclipse.ui.internal.views.markers.AllErrorsParameters org.eclipse.ui.internal.views.markers.ConfigureContentsDialogHandler org.eclipse.ui.internal.views.markers.GroupsContribution

  • [x] I understand suggesting an enhancement doesn't mandate anyone to implement it. Other contributors may consider this suggestion, or not, at their own convenience. The most efficient way to get it fixed is that I implement it myself and contribute it back as a good quality patch to the project.

eobrienPilz avatar Sep 20 '24 13:09 eobrienPilz