eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

Find/Replace Overlay: overlay is stuck sometimes when resizing panes

Open Wittmaxi opened this issue 1 year ago • 2 comments

36

possible regression after https://github.com/eclipse-platform/eclipse.platform.ui/pull/2253 @HeikoKlare what do you think?

Wittmaxi avatar Sep 20 '24 11:09 Wittmaxi

For me, this behavior came up after a recent Windows update. I see no difference in this behavior when reverting #2253. Should implicitly be fixed by #2254.

HeikoKlare avatar Sep 20 '24 11:09 HeikoKlare

@HeikoKlare I remember having issues without the PaintListener, which is why I suspected a regression. Let's anyway wait for #2254, otherwise we might be re-doing work

Wittmaxi avatar Sep 20 '24 11:09 Wittmaxi

The reason for this behavior is that the placement update is performed asynchronously, as required by GTK: https://github.com/eclipse-platform/eclipse.platform.ui/blob/1eead54aac4c037be1bbc08870ccf27aa870cfc8/bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay/FindReplaceOverlay.java#L198-L199

Making the execution synchronous leads to just-in-time updates of the replacement. We could limit the asynchronous execution to only be performed on GTK, but I am not sure whether the slight improvement for Windows and MacOS is worth an OS-specific implementation.

HeikoKlare avatar Oct 14 '24 20:10 HeikoKlare

Find/Replace overlay behavior is unacceptable, same issue i am facing latest version, i am unable to move anywhere, and seen overlay is not stable when i search anything, for details this video Screencast from 2024-11-27 20-14-01.webm

Screencast from 2024-11-27 20-14-01.webm

nandkishorv18 avatar Nov 27 '24 14:11 nandkishorv18

@nandkishorv18

That looks annoying.

I expect the coming release will be better. You can preview it here:

https://www.eclipse.org/downloads/packages/release/2024-12/rc1

Note that can switch back to using the old dialog:

image

merks avatar Nov 27 '24 14:11 merks

it has resolved using above option but i will try to upgrade latest version. thank you for instantly support

Thank you @merks

one more question?

how to upgrade this same eclipse to latest version in ubuntu? please suggest step by step,

nandkishorv18 avatar Nov 27 '24 15:11 nandkishorv18

Find/Replace overlay behavior is unacceptable, same issue i am facing latest version, i am unable to move anywhere, and seen overlay is not stable when i search anything, for details this video Screencast from 2024-11-27 20-14-01.webm

That issue is unrelated to the initially reported issue in this thread. The same issue has been reported here:

  • https://github.com/eclipse-platform/eclipse.platform.swt/issues/1447

And as mentioned by Ed, this will be fixed with the 2024-12 release.

HeikoKlare avatar Nov 27 '24 15:11 HeikoKlare

Add https://download.eclipse.org/releases/2024-12/ to the preferences

image

Then use menbar Help -> Check for Updates

That will update to RC1 (release candidate 1) of the 2024-12 release. After Dec 4th, Check for Updates will update to the release.

merks avatar Nov 27 '24 15:11 merks

@merks thank you for supporting me

nandkishorv18 avatar Nov 28 '24 05:11 nandkishorv18

Should implicitly be fixed by #2254.

Can this issue be closed?

jukzi avatar Jan 08 '25 15:01 jukzi

From my understanding, the initially reported behavior comes from Windows and is by intention, as anything else would require rather frequent repaint operations. To me, the behavior does not appear to be an issue either.

The other issue mentioned in the thread is unrelated to the original one and has already been fixed some time ago as well.

Thus closing.

HeikoKlare avatar Jan 08 '25 15:01 HeikoKlare