eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

SearchHistoryMenu: improve scrolling through selection with arrow keys

Open Wittmaxi opened this issue 1 year ago • 4 comments

Scrolling through the selection of the Search History now correctly starts at the first item and cycles through the boundaries (ie. scrolling down from the last item returns correctly to the first item of the list)

fixes #2139

34

Wittmaxi avatar Sep 02 '24 11:09 Wittmaxi

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 43m 59s :stopwatch: + 1m 39s  7 709 tests ±0   7 481 :white_check_mark: ±0  228 :zzz: ±0  0 :x: ±0  24 288 runs  ±0  23 541 :white_check_mark: ±0  747 :zzz: ±0  0 :x: ±0 

Results for commit ad270249. ± Comparison against base commit 6d7fa392.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 02 '24 11:09 github-actions[bot]

The hover is now sticky such that the navigation with the arrow keys resumes from the position where the last hover happened. This also meant that some state (the scrol positoin) had to be moved into the entire Search History Menu instead of in the key listener (see comment above).

That way, I could fix the comment about using the adapter for the listener on the fly.

Wittmaxi avatar Sep 10 '24 16:09 Wittmaxi

@HeikoKlare if this is fine with you, I will merge by end of day

Wittmaxi avatar Sep 20 '24 11:09 Wittmaxi

Verified on the below build applying the pr and i am able to select 1st entry when using down arrow key on Find/replace overlay.

Eclipse SDK Version: 2024-12 (4.34) Build id: I20240923-1800 OS: Windows 11, v.10.0, x86_64 / win32 Java vendor: Eclipse Adoptium Java runtime version: 21.0.1+12-LTS Java version: 21.0.1

deepika-u avatar Sep 24 '24 07:09 deepika-u