eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard
verified publisher icon eclipse-platform

Implement ActivitySupport filtering for DynamicContributionContributionItem

Open raghucssit opened this issue 1 year ago • 2 comments

org.eclipse.e4.ui.workbench.renderers.swt.DynamicContributionContributionItem is a Contribution Item contributed by E4 Application model. This does not support Activity Support filtering like org.eclipse.ui.internal.PluginActionContributionItem.

An example Window-->Spies Menu Item is visible even if we disable Plug-in Development Activity in Window-->Preferences-->General-->Capabilities-->Development-->Plug-in Development. Note that, Activity Support workin fine for other E3 components like views, wizards etc. spies-menu-item

I tried to implement this support at org.eclipse.e4.ui.workbench.renderers.swt.DynamicContributionContributionItem but org.ecliplse.ui.workbench is not accessible here to access PlatformUI.getWorkbench().getActivitySupport() due to cyclic dependency. I need some suggestion on how to achieve this.

raghucssit avatar Aug 25 '24 21:08 raghucssit

Note: the very same views are also not filtered in Ctrl+3 dialog if PDE activity is disabled, so there is more work to be done to fully hide them.

iloveeclipse avatar Oct 08 '24 11:10 iloveeclipse

Note: the very same views are also not filtered in Ctrl+3 dialog if PDE activity is disabled, so there is more work to be done to fully hide them.

Sad. It is not filtering in Quick Access. I will check. image

raghucssit avatar Oct 08 '24 11:10 raghucssit

I believe this is done now via https://github.com/eclipse-platform/eclipse.platform.ui/pull/2768

iloveeclipse avatar Feb 06 '25 07:02 iloveeclipse