eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

Find/Replace Overlay: store overlay options

Open Wittmaxi opened this issue 1 year ago • 3 comments

Stores the search options of the overlay and actively reloads them, even when switching between overlays.

fixes #2055 30

Wittmaxi avatar Jul 08 '24 13:07 Wittmaxi

Test Results

 1 210 files   -   605   1 210 suites   - 605   1h 4m 9s :stopwatch: - 32m 12s  7 667 tests +    4   7 435 :white_check_mark: +    1  231 :zzz: +  3  1 :x: ±0  16 108 runs   - 8 042  15 594 :white_check_mark:  - 7 806  513 :zzz:  - 236  1 :x: ±0 

For more details on these failures, see this check.

Results for commit 7df575a1. ± Comparison against base commit 118f8251.

This pull request skips 3 tests.
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.WorkbenchPluginTest ‑ testGetImageRegistryFromAdditionalDisplay
org.eclipse.jface.text.tests.contentassist.ContextInformationTest ‑ testContextInfo_hide_focusOut
org.eclipse.urischeme.internal.registration.TestUnitWinRegistry ‑ testWinRegistry

github-actions[bot] avatar Jul 08 '24 14:07 github-actions[bot]

@HeikoKlare We had discussed that this PR is not yet ready because we were not quite sure how storing overlay options should act. Can you please update me if you had any new insights into this functionality? If not, we should move this PR from the "medium" prio to the "unclear" prio until we have a better idea of what we want!

Wittmaxi avatar Aug 23 '24 07:08 Wittmaxi

I've answered in https://github.com/eclipse-platform/eclipse.platform.ui/issues/2055#issuecomment-2307361524, as the discussion rather belongs to the issue than the solution (as the latter might change while the issue remains the same).

HeikoKlare avatar Aug 23 '24 15:08 HeikoKlare

converted to a draft: the expected behavior needs to be detailed out

Wittmaxi avatar Oct 16 '24 12:10 Wittmaxi