eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

Code mining sometimes leaves some empty lines

Open reto-hoehener opened this issue 1 year ago • 5 comments

I was asked to report this here from https://github.com/eclipse-wildwebdeveloper/wildwebdeveloper/issues/1603

image

Reproduce: Eclipse 2024-03, create new xml file, open with both wtp and wwd xml editors. Enable XML CodeLens: image

reto-hoehener avatar Jun 12 '24 08:06 reto-hoehener

It appears that the WWD setting also affects the WTP editor.

reto-hoehener avatar Jun 12 '24 08:06 reto-hoehener

It appears that the WWD setting also affects the WTP editor.

Neither one belongs to the platform. Please open a bug for the appropriate project.

iloveeclipse avatar Jun 12 '24 08:06 iloveeclipse

I'm reopening. The issue was initially posted to wild web developer, but still a part of the issue belongs to Platform: there should be no empty line.

mickaelistria avatar Jun 12 '24 08:06 mickaelistria

there should be no empty line.

Isn't that added by the "CodeLens" which isn't part of the platform? Please explain why do you think the problem belongs to platform.

iloveeclipse avatar Jun 12 '24 08:06 iloveeclipse

The empty line is most likely garbage of the code mining renderer. I'll double check but I don't think the XML language server sends any codelens between line 1 and 2, so the empty line here seems wrong.

mickaelistria avatar Jun 12 '24 08:06 mickaelistria