Proposal: Opening/Closing Mechanism for Zip Files

[Michael5601]

Proposal: Opening/Closing Mechanism for Zip Files

Background

The Eclipse IDE has no built in functionality to open Zip Files and read or manipulate their content. Because of this, other operations like searching inside of Zip Files or comparing two Zip Files were also not possible.

Description

This PR introduces UI support for accesing the opening/closing mechanism for Zip Files over the UI-menu. It is accessed by right-clicking the Zip File that should be opened and then clicking on "Open Zip File". Closing is accessed the same way but when right-clicking an opened Zip File.

Please see Plaform PR for the PR on the repository eclipse.platform for the platform implementation and further information.

Co-Authored-By: CodeLtDave [email protected]

[jukzi]

Please post some screenshots about the workflow.

[Michael5601]

I want to clarify the workflow with the following screenshots:

At first the Zip File is closed and it is not possible to view/modify or search its contents.

By right-clicking and selection "Open Zip File" the Zip File can be opened.

Opening the Zip File allows using it like a normal folder with all operations supported.

Opening a resource inside of the zip opens the editor for the resource.

Opened Zip Files can be closed by right-clicking and selecting "Close Zip File".

After closing the zip file we have the same state as in the beginning.

For other archive types than "zip" the button will not show in the menu when right-clicking the archive. I hope these screenshots could help to understand the workflow.

[jukzi]

I hope these screenshots could help to understand the workflow.

Makes sense. I would have expected open/close to be more at the top, as the normal "Open" action is:

[jukzi]

Just another idea: explicit open/closing zipfiles could be avoided by adding a node "Archives" like JDT already does for "Referenced Libraries" which makes it possible to explore the zip files contents too.

[github-actions[bot]]

Test Results

0 files   -  1 815  0 suites   - 1 815   0s :stopwatch: - 1h 31m 7s 0 tests  -  7 636  0 :white_check_mark:  -  7 408  0 :zzz:  - 228  0 :x: ±0  0 runs   - 24 069  0 :white_check_mark:  - 23 320  0 :zzz:  - 749  0 :x: ±0 

Results for commit 91f9a51a. ± Comparison against base commit 385b30bb.

[Michael5601]

Just another idea: explicit open/closing zipfiles could be avoided by adding a node "Archives" like JDT already does for "Referenced Libraries" which makes it possible to explore the zip files contents too.

This was our initial approach to the topic, though I don't recall the exact reasons we decided against it, given the time that has passed. The main issue, I believe, was that this window relies on JDT, while we wanted to exclusively use platform content. Additionally, the search functionality only targets content within the local workspace. Since our project aimed to improve the file search at first, we quickly abandoned the JDT approach. If you know a specific way how this could work with JDT we can also examine it further.