eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

FocusCellOwnerDrawHighlighter doesn't remove the complete selection information

Open Christopher-Hermann opened this issue 1 year ago • 1 comments

Steps to reproduce

From a fresh installation and clean workspace: This is a follow up to https://github.com/eclipse-platform/eclipse.platform.ui/pull/1689

Steps to reproduce

  • Import the ZIP file mentioned in https://github.com/eclipse-platform/eclipse.platform.ui/pull/1689 as project
  • Execute command "Open focus cell demo"
  • Change the selection from the first line, first column to the first line, second column

A small line with the selection color can be seen in the first cell, see screenshot: Bildschirmfoto 2024-05-08 um 15 21 43

Here is some input on the issue

https://github.com/eclipse-platform/eclipse.platform.ui/blob/1cd9f4f0595686824cf63d43692c9eaefcbbf35b/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/FocusCellOwnerDrawHighlighter.java#L108-L118 The FocusCellOwnerDrawHighlighter removes the selection information of the selected line so that only the selected cell is highlighted. Somehow not the complete selected area is removed.

Community

  • [/] I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.

Christopher-Hermann avatar May 08 '24 13:05 Christopher-Hermann

@Christopher-Hermann thank you for reporting it!

I assigned this issue to you as requested in https://github.com/eclipse-platform/eclipse.platform.ui/pull/1690#issuecomment-2100575227.

fedejeanne avatar May 08 '24 13:05 fedejeanne