Double Separators can be created with empty DynamicMenuContributions

[N1k145]

Let's make sure issue is not already fixed in latest builds first.

• [x] I verified I can reproduce this issue against latest Integration Build of Eclipse SDK

Steps to reproduce

AFAIK, JFace has a logic to remove double Separators from Context Menus. But this only works if they are next to each other after the contributions are collected. When some of these contributions do not contribute anything, the double Separators are not removed.

I tried: The Second Contribution in this screenshot creates a dynamic menu contribution and a separator before that. The dynamic contribution does not add any elements (This could be the case that in the current selection, none of the possible results are valid, depending on implementation)

I expected: That the double and end separators are removed

But got: There is a Separator at the end of the Context Menu that is not removed.

Tested under this environment:

• OS & version: Windows 11 and Linux
• Eclipse IDE/Platform version (as shown in Help > About): latest 2024-03

Community

• [x] I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.