eclipse-platform
Improve "Viewer limits" preference page
This is related #1425 and #818.
The feature has a lengthy label in the preference page and a really long tool tip:
Furthermore the wording is different. In preference it says something about "elements" while in views it is about "items".
- Could the lengthy label and tool tip be shortened and instead added to the help page of the preference page?
- I know there is no specific pref page for viewers. But now the setting is located between "Show heap status" and "Rename inline". Is there a better location in the preferences? E.g. in Appearance?
- If the number is lowered from 1000 to e.g. 50, one may see it in action e.g. in project explorer. I did this. And I would find it helpful, if it does not do it on root level, at least in Project Explorer. I find it weird to first click it a few times to see all my projects. Could there be a special preference "Do not limit on root level"?
This is just my observations and some proposals for improvement. No blaming.
2. know there is no specific pref page for viewers. But now the setting is located between "Show heap status" and "Rename inline". Is there a better location in the preferences? E.g. in Appearance?
I would also propose the "Appearance" preference page as a better place. And if you look at the "technical name" of that page is ViewsPreferencePage.java. So this also gives a hint that this may be a good fit.
3. Could there be a special preference "Do not limit on root level"?
As the tooltip says it's only a hint: Maybe the project explorer implementation could be change to ignore this setting on root level at all.
Maybe the project explorer implementation could be change to ignore this setting on root level at all.
This feature is generic and doesn't provide a way to limit some parts or levels and not limit others.
If the number is lowered from 1000 to e.g. 50, one may see it in action e.g. in project explorer.
The main driving force behind the implementation is to avoid UI hangs, so default value is 1000. Setting UI to smaller limit makes no sense except for testing.
With that, we (Advantest) do not plan to introduce yet another option and make code more complex just because of Package Explorer doesn't show all projects with the unusually small limit. This is not an important use case for us, and, I believe, also nkt important for most of the users.
For the rest: it is hard to find wording that would explain a technically very complex feature in few words, but if someone has a better proposal, just push a PR for discussion. Similar for the preference page.
just push a PR for discussion
I compiled a first version for the documentation out of your New & Noteworthy entry into https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/1775. Feedback welcome.
This is the closest I could find to report a related problem: Please have a look at https://www.eclipse.org/forums/index.php/m/1864776/#msg_1864776 - is this problem due to this "Viewer limits" feature? If not - please remove this comment thanks!
Found in https://github.com/eclipse-platform/eclipse.platform.ui/issues/1674#issuecomment-2017386631
No the spacing is https://github.com/eclipse-platform/eclipse.platform.ui/issues/1674
