eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

increase transparency of showKeyPopUp

Open elsazac opened this issue 1 year ago • 9 comments

Fixes: #48

image

The text behind is partly visible now though at the expanse of transparency to the key shortcut text

elsazac avatar Jan 30 '24 10:01 elsazac

Test Results

   918 files  ±0     918 suites  ±0   47m 12s :stopwatch: - 2m 15s  7 439 tests ±0   7 286 :white_check_mark: ±0  152 :zzz: ±0  1 :x: ±0  23 466 runs  ±0  22 957 :white_check_mark: ±0  508 :zzz: ±0  1 :x: ±0 

For more details on these failures, see this check.

Results for commit d3f9759d. ± Comparison against base commit f0b1071e.

github-actions[bot] avatar Jan 30 '24 11:01 github-actions[bot]

Please also test with a light theme / background ...

laeubi avatar Jan 30 '24 12:01 laeubi

Please also test with a light theme / background ...

I did. In the light theme it also works fine - maybe even better...

BeckerWdf avatar Jan 30 '24 12:01 BeckerWdf

Please also test with a light theme / background ...

image

This is the appearance in light theme.Does this look good?

elsazac avatar Jan 30 '24 12:01 elsazac

image

BeckerWdf avatar Jan 30 '24 12:01 BeckerWdf

It is a bit hard to tell, but can we make the background only transparent but the text opaque.... the screen looks like underlying text is shining though the text what makes it very hard to read.

laeubi avatar Jan 30 '24 12:01 laeubi

image

I find the text underneath (Moves the ...) hardly readable now if I wouldn't know what is supposed to be there...

laeubi avatar Jan 30 '24 12:01 laeubi

I find the text underneath (Moves the ...) hardly readable now if I wouldn't know what is supposed to be there...

@laeubi For some reason I can't see the picture you posted.

elsazac avatar Jan 31 '24 07:01 elsazac

It is from this comment https://github.com/eclipse-platform/eclipse.platform.ui/pull/1592#issuecomment-1916751813

laeubi avatar Jan 31 '24 07:01 laeubi