579498 filter dialog types

[eobrienPilz]

We have a customized problem view for our application. It displays markers of our own type pilzproblemmarker

i.e.

Defined like this. <extension point="org.eclipse.core.resources.markers" id="pilzproblemmarker" name="pilz problem marker"> <super type="org.eclipse.core.resources.problemmarker"> </super> .......

We associate it with the problem view like this. <extension point="org.eclipse.ui.ide.markerSupport"> id="com.pilz.pas.platform.gui.pilzproblemmarker"/>

We create our markers like this with our custom marker as a super. <extension point="org.eclipse.core.resources.markers" id="com.pilz.pas.hal.errorhandling.ErrorCodes.STATEMENT_INDEX_OUT_OF_BOUNDS" name="%SUPPRESSION_MSG_STATEMENT_INDEX_OUT_OF_BOUNDS"> <super type="com.pilz.pas.platform.gui.pilzproblemmarker"> </super> .......

This works well with the filter dialog.

1. All our markers get displayed in the type section of the filter dialog.
2. Other problem markers that we don't care about (e.g. Java problems) are not displayed.

Only issue is that the supertype pilzproblemmarker is shown : see the screenshot We need to hide it.

[eobrienPilz]

Link to the bugzilla issue: https://bugs.eclipse.org/bugs/show_bug.cgi?id=579498

I just added a comment there describing the patch proposal

[eobrienPilz]

The version in the Manifest needs to be updated.

16:42:27.335 [ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:3.0.0-SNAPSHOT:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.ui.ide: Only qualifier changed for (org.eclipse.ui.ide/3.19.0.v20220610-1747). Expected to have bigger x.y.z than what is available in baseline (3.19.0.v20220511-1638) -> [Help 1]

• I do not understand the issue - could you provide screenshots before/after?
• new files need a copyright in the header
• please avoid newline changes.

API

Are there guidelines somewhere on what the version should be ?

Should I change from Bundle-Version: 3.19.0.qualifier to Bundle-Version: 3.19.1.qualifier

[jukzi]

Bundle-Version: 3.19.1.qualifier

we increase by 100. see https://wiki.eclipse.org/Version_Numbering#When_to_change_the_service_segment 3.19.100

[eobrienPilz]

Bundle-Version: 3.19.1.qualifier

we increase by 100. see https://wiki.eclipse.org/Version_Numbering#When_to_change_the_service_segment 3.19.100

Reading the wiki its still not clear if it should be a minor change or a service change. The extension point has changed so I thought maybe it should be minor. However if I increase minor to 3.20.0 I get an error from API Analysis in eclipse saying there is no API change.

[jukzi]

Reading the wiki its still not clear if it should be a minor change or a service change. The extension point has changed so I thought maybe it should be minor. However if I increase minor to 3.20.0 I get an error from API Analysis in eclipse saying there is no API change.

It's not a binary break that the API Analysis detects. However it is an API change. Some guru can force an increase to 3.20 but let's wait if others agree about that change.

[github-actions[bot]]

Test Results

 1 818 files  + 3   1 818 suites  +3   1h 41m 29s :stopwatch: + 3m 33s  7 708 tests + 4   7 480 :white_check_mark: + 5  228 :zzz: ±0  0 :x:  - 1  24 285 runs  +12  23 538 :white_check_mark: +13  747 :zzz: ±0  0 :x:  - 1 

Results for commit 7401cf79. ± Comparison against base commit a431d71a.

:recycle: This comment has been updated with latest results.