eclipse.platform.swt icon indicating copy to clipboard operation
eclipse.platform.swt copied to clipboard

Parameterize browser tests to execute them for Edge browser #671

Open HeikoKlare opened this issue 2 years ago • 4 comments

Browser tests were only executed for the default configuration of a system's browser using the SWT.NONE flag. Other configurations, such as using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also execute them for the Edge browser on Windows. It also deactivates those tests for the Edge browser for which the implementation does (currently) not work. This allows to detect regressions when performing future changes to the Edge browser.

Fixes https://github.com/eclipse-platform/eclipse.platform.swt/issues/671

HeikoKlare avatar May 15 '23 17:05 HeikoKlare

Test Results

   383 files  ±  0     383 suites  ±0   6m 14s ⏱️ + 1m 15s  4 284 tests ±  0   4 274 ✅ +  3  10 💤  - 3  0 ❌ ±0  12 336 runs  +189  12 245 ✅ +181  91 💤 +8  0 ❌ ±0 

Results for commit 9e665c15. ± Comparison against base commit 9339c929.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 15 '23 18:05 github-actions[bot]

@HeikoKlare can this be merged?

vogella avatar Jun 14 '23 07:06 vogella

creating browser took too long: 23469ms
java.lang.AssertionError: creating browser took too long: 23469ms
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.createBrowser(Test_org_eclipse_swt_browser_Browser.java:290)
	at org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.setUp(Test_org_eclipse_swt_browser_Browser.java:173)

jukzi avatar Jun 15 '23 10:06 jukzi

I converted this back to draft due to the recent test failure and I will have another look at it. Further increasing the waiting time between test cases would probably "solve"(/hide) the problem, but I'd prefer a solution that makes waiting times between test cases obsolete.

HeikoKlare avatar Jun 16 '23 12:06 HeikoKlare

Test failures in Linux are unrelated #1564

fedejeanne avatar Dec 16 '24 16:12 fedejeanne