eclipse.platform.swt icon indicating copy to clipboard operation
eclipse.platform.swt copied to clipboard

Javadoc basher changes for 4.38

Open deepika-u opened this issue 1 month ago • 7 comments

SWT Javadoc bash for 4.38

Fixes https://github.com/eclipse-platform/eclipse.platform.swt/issues/2788

deepika-u avatar Nov 17 '25 10:11 deepika-u

@HeikoKlare These are javadoc updates being generated by javadocbasher, can you take a look when you get some time.

But please dont close the task #2788, it is to be merged in RC2 only after verifying it.

deepika-u avatar Nov 17 '25 10:11 deepika-u

Test Results

  118 files  ±0    118 suites  ±0   15m 36s ⏱️ - 2m 10s 4 653 tests ±0  4 635 ✅  - 1  18 💤 +1  0 ❌ ±0    338 runs  ±0    334 ✅ ±0   4 💤 ±0  0 ❌ ±0 

Results for commit 9fec50c1. ± Comparison against base commit 28bb9b45.

This pull request skips 1 test.
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser_IE ‑ test_setUrl_remote_with_post

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Nov 17 '25 10:11 github-actions[bot]

It looks like this PR does the opposite of what should be done. The deleted comment should instead be added in windows/mac javadoc too.

akurtakov avatar Nov 17 '25 11:11 akurtakov

Thanks for catching that! You’re absolutely right — I misunderstood the requirement and ended up doing the opposite of what was intended. I’ll update the PR to add the latest changes.

deepika-u avatar Nov 18 '25 12:11 deepika-u

I’ve updated the PR as per your suggestion - the changes are added now in Windows and Mac. Please review and let me know if everything looks good now.

deepika-u avatar Nov 18 '25 13:11 deepika-u

@akurtakov Can you take a look at this when you get some time please?

deepika-u avatar Nov 21 '25 10:11 deepika-u

@deepika-u I'm not @akurtakov ;-) - but as a fellow committer I can offer a +1 on this javadoc change as it is the one that applies to to the discussion in this issue https://github.com/eclipse-platform/eclipse.platform.swt/issues/2598

jonahgraham avatar Nov 21 '25 19:11 jonahgraham

Let's finally merge this one despite the test failure as it can't be caused by javadoc changes and happens in master even without this change.

akurtakov avatar Nov 24 '25 06:11 akurtakov

Thanks @jonahgraham @elsazac @akurtakov

deepika-u avatar Nov 24 '25 06:11 deepika-u