pdt icon indicating copy to clipboard operation
pdt copied to clipboard

How to contribute ?

Open pounard opened this issue 4 years ago • 15 comments

Hello,

I was attempting to setup Eclipse for contributing to PDT (long time I wrote Java, but hey, never too late to get back at it).

I followed the guide there: https://wiki.eclipse.org/PDT/Contributing#Quick_guide

It seems rather outdated, for starters:

  • http://download.eclipse.org/tools/orbit/downloads is not a valid update site anymore, at least my Eclipse tells me that it's not a valid repository,
  • https://git.eclipse.org/c/pdt/org.eclipse.pdt.git/plain/dev/psf/pdt-dev.psf is not a valid URL, it gives a 404 error.

Actually I'm stuck there, even though, a long time ago, I did wrote a few Eclipse plugins, things have changed drastically in 13 years.

Is there any up to date documentation ? Or did I misdone something ?

Many thanks in advance for the help.

pounard avatar Dec 04 '20 17:12 pounard

OK ! Found the right psf links there: https://projects.eclipse.org/projects/tools.pdt/developer : https://raw.githubusercontent.com/eclipse/pdt/master/dev/psf/pdt-dev.psf

I'll continue and come back on this issue if I encounter any other problem. Sorry for the noise !

pounard avatar Dec 04 '20 17:12 pounard

OK, imported the project, I now have 3594 problems ! 2080 errors, 1510 warnings (OK I can ignore those), and 4 others. Are the problems in the problem view normal ?

I got errors such as:

Description	Resource	Path	Location	Type
An API baseline has not been set for the current workspace.	org.eclipse.php.astview		Unknown	Default API Baseline Problem

Or a lot of those as well:

Description	Resource	Path	Location	Type
ArrayUtils cannot be resolved	ASTRewrite.java	/org.eclipse.php.core/src/org/eclipse/php/internal/core/ast/rewrite	line 579	Java Problem

Can I ignore those safely ?

pounard avatar Dec 04 '20 17:12 pounard

OK, did that: "(Optional) Disable API Baselines errors (Window → Preferences menu item, then Plug-in Development → API Baselines, then choose Missing API baseline → Ignore)"

Now I have only 3576 problems :)

pounard avatar Dec 04 '20 17:12 pounard

Pfiou, that was really a long time ago I worked on Eclipse plugins, after the first run, I no longer have all those errors, only one remaining. I forgot about that !

Good job, it works !

Still got one problem thought:

Unknown extension point: 'org.eclipse.wildwebdeveloper.json.schema'	plugin.xml	/org.eclipse.php.composer.core	line 157	Plug-in Problem

I guess the quick startup is missing a few dependencies to install, I'll try to poke things around and see if I manage to find my way in PDT.

pounard avatar Dec 04 '20 17:12 pounard

@pounard you can update the contributing wiki page yourself

mlocati avatar Dec 04 '20 17:12 mlocati

I can do that ?

I'll have to find my Eclipse account login, I didn't sign in recently.

pounard avatar Dec 04 '20 17:12 pounard

I don't remember, maybe you first need to login, then you should see an Edit button somewhere

mlocati avatar Dec 04 '20 17:12 mlocati

About contributing to the wiki page, I'm not sure of myself enough right now. For example, regarding the Orbit dependency update site that's wrong, how I could find the right one ? How could I tell if it's still required or not ? My guess is that it might be not, since I managed to run it.

pounard avatar Dec 04 '20 17:12 pounard

Fun continues, I cannot run tests:

Required plug-in 'org.eclipse.jdt.junit.runtime' could not be found.

I'm searching the web for help about this, I can't find anything related to JUnit in the software updater.

pounard avatar Dec 04 '20 17:12 pounard

My simple solution:

  1. Install Eclipse for Committers: https://www.eclipse.org/downloads/packages/release/2020-09/r/eclipse-ide-eclipse-committers
  2. Install DLTK and PDT: https://download.eclipse.org/tools/pdt/updates/latest-nightly/ and https://download.eclipse.org/technology/dltk/updates-dev/latest-nightly/
  3. Import maven projects

zulus avatar Dec 08 '20 10:12 zulus

@zulus exactly what I ended up doing ! But I still get errors related to junit. I'll retry from scratch using a clean install.

pounard avatar Dec 08 '20 10:12 pounard

@pounard @zulus I agree wiki page and README file should be updated to how correctly checkout project structure and start hacking.

ibakirov avatar Dec 17 '21 12:12 ibakirov

@ibakirov @pounard @zulus I did create pull request #136 to leverage the Maven import procedure getting a proper Eclipse IDE set up. Please review the pull request. After that one the Wiki page can be updated accordingly. The steps of the procedure are described by the pull request comment. Please note that pull request #135 is required in addition to get rid of a plugin.xml error marker.

mhoffrog avatar May 24 '22 22:05 mhoffrog

@mhoffrog very nice ! Thanks, I'll try when I can, in the meantime since I opened this issue, two kids happened, so time is something I don't have much anymore...

pounard avatar May 25 '22 14:05 pounard

@mhoffrog Thanks for your effort, I will try to follow pull request and by the way I rarely use Eclipse

ibakirov avatar May 26 '22 07:05 ibakirov